Skip to content

Fix puppeteer 25 esm #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LanieOkorodudu wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix puppeteer 25 esm #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b348b
Bump puppeteer from 23.6.0 to 25.12.0
dependabot[bot] Oct 5, 2026
99a54aa
Fix Puppeteer 25 ESM compatibility
LanieOkorodudu Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions __tests__/configuration_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
const puppeteer = require("puppeteer");
let puppeteer;
const { BASE_URL } = require("../scripts/testBaseUrl");

const FIRST_THUMB_SRC =
"https://iiif.wellcomecollection.org/image/b18035723_0001.JP2/full/90,/0/default.jpg";

let browser;
let page;
let page;

// Applies custom config through the examples page's Configuration tab:
// the #customConfig JSON is merged into the viewer config by a
Expand All @@ -21,14 +21,15 @@ const applyCustomConfig = async (config) => {

describe("Configuration options", () => {
beforeAll(async () => {
puppeteer = (await import("puppeteer")).default;
browser = await puppeteer.launch();
page = await browser.newPage();
});

afterAll(async () => {
await browser.close();
});

describe("thumb cache invalidation", () => {
beforeEach(async () => {
await page.goto(BASE_URL);
Expand Down
3 changes: 2 additions & 1 deletion __tests__/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
test.skip("Configuration options", () => {});

const puppeteer = require("puppeteer");
let puppeteer;
const { BASE_URL } = require("../scripts/testBaseUrl");

// Cookbook manifest for viewer control tests
Expand Down Expand Up @@ -89,6 +89,7 @@ describe("Universal Viewer", () => {
};

beforeAll(async () => {
puppeteer = (await import("puppeteer")).default;
browser = await puppeteer.launch();
page = await browser.newPage();
await page.goto(BASE_URL);
Expand Down
Loading
Loading