Repository navigation
Fix puppeteer 25 esm - #1870
Open
LanieOkorodudu wants to merge 2 commits into
Open
Fix puppeteer 25 esm#1870LanieOkorodudu wants to merge 2 commits into
LanieOkorodudu wants to merge 2 commits into
Conversation
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 23.6.0 to 25.12.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v25.12.0) --- updated-dependencies: - dependency-name: puppeteer dependency-version: 25.12.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@LanieOkorodudu is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what you did:
This follows on from #1867
I've updated the tests to use dynamic
import()so they work with Puppeteer 25. I also updated the Jest test command to run--experimental-vm-modulesto support ESM. Then tested the changes locally and the test and build are all passing.