Repository navigation
fix(dry-run): allow stats and recall previews after #970 - #986
Merged
Merged
Conversation
Code Erosion ReportInformational — never blocks the merge.
Scanned 304 files / 60433 SLOC · high-CC functions 414/4823 * On TypeScript, Rule hits (TS verbosity layer)Standalone
38 distinct lines flagged across |
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#970madeteamai stats --dry-runandteamai recall <query> --dry-runwrite nothing, but the squash onto#969left both commands on the refusal list. Fork-safe E2E then exits 1 (stats-recall-dry-run.test.ts). This moves them onto the preview allowlist.digeststays refused.Type of Change
Test Plan
npx tsc --noEmitpassesnpm run lintpassesnpx vitest runpassesReal CLI, after
npm run buildon this branch:npx tsc --noEmit— passednpx vitest run src/__tests__/dry-run-guard.test.ts— 30 passednpx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/stats-recall-dry-run.test.ts src/__tests__/e2e/dry-run-refusal.test.ts— 17 passedLint was not re-run. The diff only moves two command names between string sets and updates tests.
Related Issues
Fixes the fork-safe E2E failure on PRs based on main after
#970(#974,#979,#982,#983,#985).Notes for Reviewers
The diagnostic log (
~/.teamai/debug.log) is ignored in the stats/recall dry-run snapshot, matching the other dry-run e2e suites. A preview still appends to it.