Skip to content

fix(dry-run): allow stats and recall previews after #970 - #986

Merged
jeff-r2026 merged 1 commit into
mainfrom
hotfix/stats-recall-dry-run-e2e
Oct 6, 2026
Merged

jeff-r2026 merged 1 commit into
mainfrom
hotfix/stats-recall-dry-run-e2e

Conversation

@jeff-r2026

@jeff-r2026 jeff-r2026 commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

#970 made teamai stats --dry-run and teamai recall <query> --dry-run write nothing, but the squash onto #969 left both commands on the refusal list. Fork-safe E2E then exits 1 (stats-recall-dry-run.test.ts). This moves them onto the preview allowlist. digest stays refused.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature causing existing behavior to change)
  • Documentation only
  • Refactor / internal cleanup

Test Plan

  • npx tsc --noEmit passes
  • npm run lint passes
  • npx vitest run passes
  • Added/updated tests for the change

Real CLI, after npm run build on this branch:

  • npx tsc --noEmit — passed
  • npx vitest run src/__tests__/dry-run-guard.test.ts — 30 passed
  • npx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/stats-recall-dry-run.test.ts src/__tests__/e2e/dry-run-refusal.test.ts — 17 passed

Lint was not re-run. The diff only moves two command names between string sets and updates tests.

Related Issues

Fixes the fork-safe E2E failure on PRs based on main after #970 (#974, #979, #982, #983, #985).

Notes for Reviewers

The diagnostic log (~/.teamai/debug.log) is ignored in the stats/recall dry-run snapshot, matching the other dry-run e2e suites. A preview still appends to it.

The squash of #970 onto the #969 refusal list left both commands
refused, so fork-safe e2e exits 1. The previews already write nothing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Code Erosion Report

Informational — never blocks the merge. scb-check==0.2.0 SlopCodeBench metrics; method & caveats in docs/ci-code-erosion.md.

Metric Value Human band Agent band Reading
Verbosity* 0.073 0.15 0.33 human
Erosion 0.683 0.31 0.68 agent
Cognitive erosion 0.867 – – –

Scanned 304 files / 60433 SLOC · high-CC functions 414/4823

* On TypeScript, verbosity is partial and the bands are Python-calibrated.

Rule hits (TS verbosity layer)

Standalone ast-grep, separate from the number above.

Rule Hits
unnecessary-else-after-return 32
empty-catch-block 5
redundant-ternary-same 1

38 distinct lines flagged across src/.

@jeff-r2026
jeff-r2026 merged commit 3f11504 into main Oct 6, 2026
11 checks passed
@jeff-r2026
jeff-r2026 deleted the hotfix/stats-recall-dry-run-e2e branch October 6, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant