Skip to content

[question] SessionStart MR hint ignores sharing.recall.enabled: intended? #988

Description

@SaulMoro

With recall off, TeamAI withholds the share-learnings reminder, but the SessionStart MR hint still tells members to run teamai import --from-mr. Is that intended?

recall off (sharing.recall.enabled: false, no user override)
  Stop          → contributeHintAllowed → shareGate → blocked 'recall'    silent
  SessionStart  → mrHintHandler (gitOnly + requiresConfig only)            "run teamai import --from-mr <url>"

Seen on this repo: teamai recall status reports Recall: disabled, and SessionStart still listed #986 for import.

Two readings:

  • Intended: MR learnings are worth collecting before a team turns recall on. Then the two hints disagree on purpose, and the docs should say so.
  • Bug: the hint asks members to write learnings no agent will read. Then mrHintHandler should check contributeHintAllowed, as the Stop reminder does since fix(skills): one share gate, actionable refusals, and a louder stub deploy #747, so one switch silences both.

Related: the hint says import also updates codebase.md (src/mr-hint.ts:372), but src/import-mr.ts writes only a learning. That line is Chinese CLI output too.

Code: src/hook-handlers.ts:788 (mr-hint), src/hook-handlers.ts:446 and src/skill-content.ts:149 (share gate).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions