Skip to content

Guard the missing mdia box in the MP4 track picker #13229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Aug 5, 2026
+14 −5
Merged

Guard the missing mdia box in the MP4 track picker #13229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/ui/Features/Shared/PickMp4Track/PickMp4TrackViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,22 @@ public void Initialize(List<Trak> mp4Tracks, string fileName)
WindowTitle = $"Pick MP4 track - {fileName}";
foreach (var track in _mp4Tracks)
{
// A trak box without an mdia child carries no media information at all;
// Mp4Parser.GetSubtitleTracks() already drops those, but the callers are
// free to hand us any track list.
var mdia = track.Mdia;
if (mdia == null)
{
continue;
}

var display = new Mp4TrackInfoDisplay
{
HandlerType = track.Mdia.HandlerType,
Name = track.Mdia.Name,
StartPosition = track.Mdia.StartPosition,
IsVobSubSubtitle = track.Mdia.IsVobSubSubtitle,
Duration = LastCueEnd(track.Mdia?.Minf?.Stbl?.GetParagraphs()),
HandlerType = mdia.HandlerType,
Name = mdia.Name,
StartPosition = mdia.StartPosition,
IsVobSubSubtitle = mdia.IsVobSubSubtitle,
Duration = LastCueEnd(mdia.Minf?.Stbl?.GetParagraphs()),
Track = track,
};
Tracks.Add(display);
Expand Down