Test symbolic jump affects through public API#1509
Merged
ChrisRackauckas merged 1 commit intoJul 21, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 13, 2026
Member
Author
|
CI classification after the required clean-master audit:
Neither red check is caused by this focused parent_sys/public-API change. No test was skipped, silenced, or loosened. |
This was referenced Jul 15, 2026
ChrisRackauckas
marked this pull request as ready for review
July 21, 2026 15:39
ChrisRackauckas-Claude
referenced
this pull request
Jul 23, 2026
Co-authored-by: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
ModelingToolkit commit 136462c52d4c983e4ba832893928f270bc399b47 changed the internal AffectSystem constructor to require parent_sys. Catalyst called that non-public constructor directly in symbolic_stoichiometry.jl, so both ModelingToolkit Catalyst Modeling lanes failed with UndefKeywordError.
A behavioral boundary check passed on parent 0b01708ffb4c545b888f859bdcbc505350f723ef, and git bisect identifies 136462c52d4c983e4ba832893928f270bc399b47 as the first bad commit.
Validation
The repository-wide Runic 1.7.0 check still exits 1 on pre-existing formatting in this test file outside the touched ranges; this PR does not mix that broad formatting cleanup into the regression fix.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.