Test graph edge order without symbolic repr#1515
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Investigation scratchpad
Final local validation on commit
|
Member
Author
|
CI watch update — final terminal state
No #1515 code change is indicated by the remaining red checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComplexGraphWrap.reprstrings whose commutative factor order changes across Symbolics versions.edgelist[rxorder] == Graphs.edges(img)assertion unchanged.Root cause
Commit
a815230d89c2b21c7f9322545043f922654fc6f1changed the label-order assertion from@testto@test_broken. Under the downgrade workflow's outer-Catalyst load order, the equality already passes, so@test_brokenraises an Unexpected Pass. Under the current standalone Extensions environment, Symbolics prints the same commutative product asB(t)*k5rather thank5*B(t), so a literal string assertion cannot be valid in both supported environments.edgelabelsis deterministically derived fromreactions(rn), whilerxorderis the mapping under test. Assertingrxorder == [1, 4, 6, 2, 5, 3]preserves the complete ordering invariant without coupling the test to symbolic pretty-printing.Local validation
GROUP=Extensions julia +1.10 --project=. -e 'using Pkg; Pkg.test()'— passed, including Graph visualization 25/25 and the full Extensions group.