Skip to content

Claude/ci windows target fix #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderickvd merged 2 commits into from
Aug 23, 2026
+12 −6
Merged

Claude/ci windows target fix #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d0b24
fix(ci): build the Windows matrix for its target triple
ErwanLegrand Aug 22, 2026
62c61df
fix(ci): lint the 32-bit Windows target
ErwanLegrand Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/platforms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,20 +265,20 @@ jobs:
key: windows-${{ matrix.arch }}

- name: Run tests (default features)
run: cargo +${{ env.MSRV_WINDOWS }} test --workspace --verbose
run: cargo +${{ env.MSRV_WINDOWS }} test --workspace --verbose --target ${{ env.TARGET }}

- name: Check examples (default features)
run: cargo +${{ env.MSRV_WINDOWS }} check --examples --workspace --verbose
run: cargo +${{ env.MSRV_WINDOWS }} check --examples --workspace --verbose --target ${{ env.TARGET }}

- name: Run tests (all features)
run: cargo +${{ steps.msrv.outputs.all-features }} test --workspace --all-features --verbose
run: cargo +${{ steps.msrv.outputs.all-features }} test --workspace --all-features --verbose --target ${{ env.TARGET }}

- name: Check examples (all features)
run: cargo +${{ steps.msrv.outputs.all-features }} check --examples --all-features --workspace --verbose
run: cargo +${{ steps.msrv.outputs.all-features }} check --examples --all-features --workspace --verbose --target ${{ env.TARGET }}

- name: Build ASIO examples
working-directory: asio-sys
run: cargo +${{ env.MSRV_WINDOWS }} build --examples --verbose --workspace
run: cargo +${{ env.MSRV_WINDOWS }} build --examples --verbose --workspace --target ${{ env.TARGET }}

# macOS ARM64
macos:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ jobs:

# Windows - WASAPI backend
- target: x86_64-pc-windows-msvc
name: Windows
name: Windows-x64
features: --all-features
os: windows-latest

# Windows 32-bit - WASAPI backend
- target: i686-pc-windows-msvc
name: Windows-x86
features: --all-features
os: windows-latest

Expand Down
Loading