Claude/ci windows target fix - #1338
Merged
roderickvd merged 2 commits intoAug 23, 2026
Merged
Conversation
The windows job takes a target per matrix arm, exports it as TARGET and installs it for both toolchains, but no cargo invocation passed --target. Every step therefore built and tested the host triple, so the i686 arm silently duplicated the x64 one and 32-bit Windows was never covered.
The clippy matrix only covered x86_64-pc-windows-msvc, so i686 built in the platform workflow without ever being linted under -D warnings. Name the two arms Windows-x64 and Windows-x86, matching the x64/x86 vocabulary platforms.yml already uses for the same two targets. This renames the existing clippy-Windows check.
ErwanLegrand
changed the title
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Windows on both x86 and x64 in CI.