CherryPicked: [cnv-4.22] [Storage] Increase libguestfs pod timeout#5426
Merged
Merged
Conversation
##### What this PR does / why we need it: Increase the timeout from TIMEOUT_1MIN (60s) to TIMEOUT_10MIN (600s) to match the product's own 500-second timeout for the libguestfs pod to reach Running state. The product code at [pkg/virtctl/guestfs/guestfs.go](https://github.com/kubevirt/kubevirt/blob/759a3049c9d1fad35bdb06205207aec277f6b112/pkg/virtctl/guestfs/guestfs.go#L67) defines timeout = 500 * time.Second for this same operation. ##### Which issue(s) this PR fixes: Test failures on different lanes. ##### Special notes for reviewer: ##### jira-ticket: <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> CNV-62312 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Improved reliability of pod readiness checks by increasing the wait timeout when using `libguestfs-tools-*` in the `virtctl_libguestfs_by_user` fixture. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Emanuele Prella <eprella@redhat.com>
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Custom Commands
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-6
requested review from
Ahmad-Hafe,
acinko-rh,
jpeimer and
kshvaika
June 29, 2026 07:29
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
/build-and-push-container |
|
Verification failed for PR #5426. Execution details |
Contributor
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5426 published |
Contributor
|
/approve |
Contributor
|
/verified |
Contributor
|
/lgtm |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-5426. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published |
ema-aka-young
added a commit
to ema-aka-young/openshift-virtualization-tests
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Emanuele Prella <eprella@redhat.com>
rnetser
pushed a commit
that referenced
this pull request
Jul 9, 2026
) ##### What this PR does / why we need it: - De-quarantine test_virtctl_libguestfs_with_specific_user. - Replace HTTP import in favor of data source cloning. - Wait for the libguestfs container to be created before performing operations in it. ##### Which issue(s) this PR fixes: CNV-47594 ##### Special notes for reviewer: manual backporting #4556 and #5426 ##### jira-ticket: <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> --------- Signed-off-by: Emanuele Prella <eprella@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #5308, PR owner: ema-aka-young