[Storage] Increase libguestfs pod timeout#5308
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesLibguestfs Pod Wait Timeout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
ema-aka-young
changed the title
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot-4
requested review from
Acedus,
Ahmad-Hafe,
acinko-rh,
akalenyu,
awels,
dsanatar,
jpeimer,
kgoldbla and
kshvaika
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Verification failed for PR #5308. Execution details |
|
/lgtm |
There is not much happening other than the pull tbh, the entrypoint is bash |
- Quarantine libguestfs test due to intermittent failures - Add jira reference for tracking - Increase libguestfs timeout to 10 minutes to align with production code - Use unprivileged client in pod watcher - Update docstring for virtctl guestfs test to improve clarity Signed-off-by: Emanuele Prella <eprella@redhat.com>
ema-aka-young
force-pushed
the
increase-libguestfs-timeout
branch
from
af75449 to
f405e94
Compare
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
Clean rebase detected — no code changes compared to previous head ( |
|
/verified openshift-virtualization-tests-runner/5776 |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get PR diff to find first changed line
gh pr view 5308 --repo RedHatQE/openshift-virtualization-tests --json files,headRefName
# Get the actual diff
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5308/files | jq '.[0] | {filename, patch, sha}'Length of output: 1927 🏁 Script executed: #!/bin/bash
# Check smoke and gating markers in test_libguestfs.py
rg -n 'pytest.mark.smoke|pytest.mark.gating|pytest.mark.tier' tests/storage/test_libguestfs.py
# Also check what tests exist in the file
rg -n 'def test_' tests/storage/test_libguestfs.py
# Check for virtctl_libguestfs_by_user fixture usage
rg -n 'virtctl_libguestfs_by_user' tests/storage/test_libguestfs.pyLength of output: 803 🏁 Script executed: #!/bin/bash
# Post inline non-blocking review comment on the first changed line (position 1)
gh api \
repos/RedHatQE/openshift-virtualization-tests/pulls/5308/reviews \
--method POST \
--field event="COMMENT" \
--field commit_id="57ba960ce71cff981738f24db75101db846984db" \
--field body="" \
--field "comments[][path]=tests/storage/test_libguestfs.py" \
--field "comments[][position]=1" \
--field "comments[][body]=**Test Execution Plan**
**Run smoke tests: False**
No smoke-marked tests exist in `tests/storage/test_libguestfs.py`, and the changed symbol (`virtctl_libguestfs_by_user` fixture timeout) is not reachable from any smoke test path.
**Run gating tests: False**
No gating-marked tests exist in `tests/storage/test_libguestfs.py`, and no gating-marked test in the repository depends on the `virtctl_libguestfs_by_user` fixture.
**Affected tests to run**
\`\`\`
tests/storage/test_libguestfs.py::test_virtctl_libguestfs_with_specific_user (tier2)
\`\`\`
This is the sole test that depends on the \`virtctl_libguestfs_by_user\` fixture where \`TIMEOUT_1MIN\` → \`TIMEOUT_10MIN\` was applied. Run with a storage class that exercises the libguestfs pod path, for example:
\`\`\`
pytest -s -o log_cli=true -m tier2 --jira --skip-deprecated-api-test \
-k test_virtctl_libguestfs_with_specific_user \
--storage-class-matrix=ocs-storagecluster-ceph-rbd-virtualization
\`\`\`"Length of output: 2238 🏁 Script executed: #!/bin/bash
# Get the actual PR head commit SHA
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5308 --jq '.head.sha'Length of output: 308 🏁 Script executed: #!/bin/bash
# Use Python to construct and post the review via GitHub API
python3 << 'PYEOF'
import subprocess
import json
body = """**Test Execution Plan**
**Run smoke tests: False**
No smoke-marked tests exist in `tests/storage/test_libguestfs.py`, and the changed symbol (`virtctl_libguestfs_by_user` fixture timeout) is not reachable from any smoke test path.
**Run gating tests: False**
No gating-marked tests exist in `tests/storage/test_libguestfs.py`, and no gating-marked test in the repository depends on the `virtctl_libguestfs_by_user` fixture.
**Affected tests to run**Length of output: 1166 🏁 Script executed: #!/bin/bash
# Write the JSON payload to a temp file first, then post
cat > /tmp/review_payload.json << 'ENDJSON'
{
"commit_id": "f405e94765d44c48a70f1be8c5b81835ff0135fb",
"event": "COMMENT",
"body": "",
"comments": [
{
"path": "tests/storage/test_libguestfs.py",
"position": 1,
"body": "**Test Execution Plan**\n\n**Run smoke tests: False**\nNo smoke-marked tests exist in `tests/storage/test_libguestfs.py`, and the changed symbol (`virtctl_libguestfs_by_user` fixture timeout) is not reachable from any smoke test path.\n\n**Run gating tests: False**\nNo gating-marked tests exist in `tests/storage/test_libguestfs.py`, and no gating-marked test in the repository depends on the `virtctl_libguestfs_by_user` fixture.\n\n**Affected tests to run**\n\n```\ntests/storage/test_libguestfs.py::test_virtctl_libguestfs_with_specific_user (tier2)\n```\n\nThis is the sole test that depends on the `virtctl_libguestfs_by_user` fixture where `TIMEOUT_1MIN` \u2192 `TIMEOUT_10MIN` was applied. Run with a storage class that exercises the libguestfs pod path:\n\n```\npytest -s -o log_cli=true -m tier2 --jira --skip-deprecated-api-test \\\n -k test_virtctl_libguestfs_with_specific_user \\\n --storage-class-matrix=ocs-storagecluster-ceph-rbd-virtualization\n```"
}
]
}
ENDJSON
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5308/reviews \
--method POST \
--input /tmp/review_payload.jsonLength of output: 3318 |
@akalenyu any concerns from your end or can this PR be merged? |
Yep didn't mean to block, just a little sus this is slow and came up in tier-1 as well: |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-5308. |
|
/cherry-pick cnv-4.22 |
|
Cherry-picked PR [Storage] Increase libguestfs pod timeout into cnv-4.22: #5426 |
11 participants
What this PR does / why we need it:
Increase the timeout from TIMEOUT_1MIN (60s) to TIMEOUT_10MIN (600s) to match the product's own 500-second timeout for the libguestfs pod to reach Running state. The product code at pkg/virtctl/guestfs/guestfs.go defines timeout = 500 * time.Second for this same operation.
Which issue(s) this PR fixes:
Test failures on different lanes.
Special notes for reviewer:
jira-ticket:
CNV-62312
Summary by CodeRabbit
libguestfs-tools-*in thevirtctl_libguestfs_by_userfixture.