Remove DataSource storage class fallback from DV template helper

[RoniKishner]

What this PR does / why we need it:

When calling data_volume_template_with_source_ref_dict we should either use it with explicit storage_class field, or omit the field and use the default storage class.
Relying on the storage class of the DataSources can cause miss interpretations, while also causing issues since it is not possible to match the storage class to the DataSource, if a snap shot storage class is used.

Which issue(s) this PR fixes:

Failing tests when snapshot storage classes are set.

Special notes for reviewer:

Since we could not decide the storage class according to the VolumeSnapshot that was used when creating the VM, this is the approach we decided to use.

jira-ticket:

https://redhat.atlassian.net/browse/CNV-88988

Summary by CodeRabbit

• Bug Fixes

  • Data volumes now use only an explicitly provided storage class and no longer inherit or default from referenced sources, preventing unexpected storage-class selection.

• Tests

  • Test suite updated to validate scoped storage-class selection; test fixtures adjusted to consistently provide the chosen storage class across scopes.

[coderabbitai]

Warning

Review limit reached

@RoniKishner, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 32 minutes and 4 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 05ef4e18-7f5b-439c-a908-7cd27a66166e

📥 Commits

Reviewing files that changed from the base of the PR and between 59233f8 and 2135565.

📒 Files selected for processing (4)

• tests/conftest.py
• tests/infrastructure/golden_images/test_common_templates_data_volumes.py
• tests/storage/conftest.py
• utilities/storage.py

📝 Walkthrough

Walkthrough

data_volume_template_with_source_ref_dict now sets the DataVolume's storage_class only from its storage_class parameter (no fallback). The vm_from_golden_image_multi_storage test fixture was updated to accept storage_class_name_scope_function and pass it into the template call.

Changes

Storage class passthrough and test wiring

Layer / File(s)	Summary
DataVolume storage_class passthrough utilities/storage.py	data_volume_template_with_source_ref_dict stops deriving storage_class from the referenced DataSource and uses only the provided storage_class argument.
Fixture adds and wires scoped storage_class tests/conftest.py, tests/infrastructure/golden_images/test_common_templates_data_volumes.py, tests/storage/conftest.py	Adds storage_class_name_scope_function fixture, removes the duplicate fixture from tests/storage/conftest.py, and updates vm_from_golden_image_multi_storage to accept and pass storage_class_name_scope_function as storage_class into data_volume_template_with_source_ref_dict.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• kgoldbla
• geetikakay
• dshchedr
• rnetser
• josemacassan
• dalia-frank
• Ahmad-Hafe
• kshvaika
• ema-aka-young
• vsibirsk

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Stp Link Required	❌ Error	Newly added test file tests/infrastructure/golden_images/test_common_templates_data_volumes.py contains 3 test functions but lacks required STP/RFE/Jira links in docstrings.	Add STP/RFE/Jira link to module, class, or test function docstring. @pytest.mark.polarion alone is insufficient.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing the fallback behavior that used DataSource storage classes in the data volume template helper.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description provides clear context about changes, fixes, and special considerations. All required template sections are completed with meaningful content.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-virtualization-qe-bot-5]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• mijankow
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (a2dc143) to head (2135565).
⚠️ Report is 77 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4985      +/-   ##
==========================================
- Coverage   98.67%   98.65%   -0.02%     
==========================================
  Files          25       25              
  Lines        2487     2456      -31     
==========================================
- Hits         2454     2423      -31     
  Misses         33       33              

Flag	Coverage Δ
utilities	98.65% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-virtualization-qe-bot-4]

Clean rebase detected — no code changes compared to previous head (d211ddc).
The following labels were preserved: changes-requested-jpeimer, commented-RoniKishner.

[jpeimer]

/approve
/lgtm

[RoniKishner]

Verified gating as well.

[geetikakay]

/lgtm

[rnetser]

/approve
/lgtm

[openshift-virtualization-qe-bot-2]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

[RoniKishner]

/cherry-pick cnv-4.22

[openshift-virtualization-qe-bot]

Cherry-picked PR Remove DataSource storage class fallback from DV template helper into cnv-4.22: #5140