Skip to content

Add PC 26.2 chunk implementation mapping - #333

Open
DallasCarraher wants to merge 1 commit into
PrismarineJS:masterfrom
DallasCarraher:pc-26.2-chunk-impl
Open

DallasCarraher wants to merge 1 commit into
PrismarineJS:masterfrom
DallasCarraher:pc-26.2-chunk-impl

Conversation

@DallasCarraher

@DallasCarraher DallasCarraher commented Sep 14, 2026 •

Copy link
Copy Markdown

Summary

Minecraft 26.2 (protocol 776) uses the same chunk section format as 26.1, so it maps to the existing 1.18-family implementation here rather than needing a new one. Without this, prismarine-chunk throws No chunk implementation for pc 26.2 found for any consumer (mineflayer, etc.) as soon as minecraft-data has data for 26.2 — which it doesn't yet upstream, but does on the branch backing PrismarineJS/minecraft-data#1298.

Related work getting 26.2 fully usable end-to-end:

Test plan

  • Full test suite against minecraft-data#1298's branch: 328/328 passing
  • standard lint clean

Minecraft 26.2 (protocol 776) uses the same chunk section format as
26.1, so it maps to the existing 1.18-family implementation rather
than needing a new one. Without this, prismarine-chunk throws "No
chunk implementation for pc 26.2 found" for any consumer (mineflayer,
etc.) as soon as minecraft-data has data for 26.2.

Tested against PrismarineJS/minecraft-data#1298 (26.2 support, not
yet merged): full test suite passes (328/328), standard lint clean.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

Rechecked e3424f6 and the existing discussion.

This one-line factory dispatch addition looks ready for maintainer merge review. It routes 26.2 through the existing modern column implementation and leaves every older route unchanged; current CI passes.

It is independently reviewable, but #331/#334 contain overlapping dispatch entries. Choose one surviving hunk when landing them. Routing a version here does not by itself certify all companion 26.2 data or wire changes.

Skills used: prismarine-protocol-data-review checked the actual selected data and codec/version contract;prismarine-architecture-review checked shared ownership and compatibility; prismarine-review checked current scope and existing feedback to avoid duplicate threads.

@DallasCarraher

Copy link
Copy Markdown
Author

Thanks for the review. Noted that #331/#334 carry an overlapping dispatch entry. This PR is the standalone one-line dispatch addition, so I'll drop the duplicate hunk from #334 so only one surviving entry remains when these land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants