Repository navigation
Add PC 26.2 chunk implementation mapping - #333
DallasCarraher wants to merge 1 commit into
Conversation
Minecraft 26.2 (protocol 776) uses the same chunk section format as 26.1, so it maps to the existing 1.18-family implementation rather than needing a new one. Without this, prismarine-chunk throws "No chunk implementation for pc 26.2 found" for any consumer (mineflayer, etc.) as soon as minecraft-data has data for 26.2. Tested against PrismarineJS/minecraft-data#1298 (26.2 support, not yet merged): full test suite passes (328/328), standard lint clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Rechecked e3424f6 and the existing discussion.
This one-line factory dispatch addition looks ready for maintainer merge review. It routes 26.2 through the existing modern column implementation and leaves every older route unchanged; current CI passes.
It is independently reviewable, but #331/#334 contain overlapping dispatch entries. Choose one surviving hunk when landing them. Routing a version here does not by itself certify all companion 26.2 data or wire changes.
Skills used: prismarine-protocol-data-review checked the actual selected data and codec/version contract;prismarine-architecture-review checked shared ownership and compatibility; prismarine-review checked current scope and existing feedback to avoid duplicate threads.
Summary
Minecraft 26.2 (protocol 776) uses the same chunk section format as 26.1, so it maps to the existing 1.18-family implementation here rather than needing a new one. Without this,
prismarine-chunkthrowsNo chunk implementation for pc 26.2 foundfor any consumer (mineflayer, etc.) as soon asminecraft-datahas data for 26.2 — which it doesn't yet upstream, but does on the branch backing PrismarineJS/minecraft-data#1298.Related work getting 26.2 fully usable end-to-end:
Test plan
standardlint clean