Repository navigation
Add 26.2 to testedVersions - #4121
DallasCarraher wants to merge 1 commit into
Conversation
latestSupportedVersion is derived from the last entry in this list and gates version support at require-time (throws if minecraft-data lacks data for it), so this only merges safely once minecraft-data actually ships 26.2 data. Tested against PrismarineJS/minecraft-data#1298 (26.2 support, not yet merged), plus PrismarineJS/prismarine-chunk#333 and PrismarineJS/prismarine-physics#143 (both needed locally for the internal test suite to run at all against 26.2) and a node-minecraft-protocol fix for a missing sessionId field in the login success packet (PR incoming). With all four in place: internalTest.js's 26.2 suite passes (39/39, 1 pending). One test — "chat after a kick during login throws a descriptive error" — is flaky independent of version (fails ~1/3 runs on 26.2, and reproduces on other versions when run in isolation too); a pre-existing timing race in plugin-injection-vs-kick ordering, not something this change introduces. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Treat this as a coordinated version-integration change. Adding 26.2 to testedVersions also changes the version selected while loading Mineflayer; the currently allowed older dependencies do not all contain that support. Land/release the matching minecraft-data #1298, prismarine-chunk #333, prismarine-physics #143 and NMP #1529 support, require usable minimum versions, then run the version suite. The current failing matrix does not establish advertised 26.2 support.
Skills used: prismarine-review checked the exact head and prior feedback; prismarine-protocol-data-review traced the real codec and released dependency boundary.
Reviewed current head 206986b4c10d and existing discussion. This is a COMMENT review for maintainer consideration.
This branch has not been deployed
2 participants
Summary
latestSupportedVersionis derived from the last entry intestedVersionsand gates version support atrequire()time — mineflayer throws immediately ifminecraft-datalacks data for it. That means this only merges/releases safely once PrismarineJS/minecraft-data#1298 (26.2 data) actually ships in a minecraft-data release;minecraft-data's own semver range here (^3.114.0) doesn't need bumping.Getting 26.2 fully working also needed two sibling fixes, both already open:
No chunk implementation for pc 26.2 foundotherwise)proportionalLiquidGravitywas missing 26.2, soPhysics()construction threw during plugin injectionsessionIdfield, needed for this repo's own test harness (which hosts its own fake server) but not for connecting to a real Mojang serverTest plan
With minecraft-data#1298's branch and all three sibling fixes applied locally:
test/internalTest.js's 26.2 suite: 39/39 passing, 1 pending (consistently, across multiple runs)chat after a kick during login throws a descriptive error, is flaky independent of version — fails intermittently (~1/3 runs) on 26.2, and reproduces the same way when isolated on other versions too. Pre-existing timing race between plugin injection and an early kick, not something this change introduces.loadPlugins()(pathfinder, collectblock, pvp, tool, armor-manager) against a real vanilla 26.2 server — bot spawned, pathfinder physically navigated to and reached a goal.