Repository navigation
Add clientTickEndPacket feature flag (1.21.3+) - #1334
Open
maebahesioru wants to merge 1 commit into
Open
maebahesioru wants to merge 1 commit into
maebahesioru wants to merge 1 commit into
Conversation
1 task done
Found live-testing mineflayer against a local 26.3 server: decompiling ServerGamePacketListenerImpl showed the server only clears its per-tick receivedPositionThisTick/receivedMovementThisTick bookkeeping when it receives a serverbound tick_end packet (handleClientTickEnd). A client that never sends tick_end gets that flag stuck true after its first position-bearing move packet, so the *second* one ever sent -- no matter how much later -- gets it kicked with multiplayer.disconnect.invalid_player_movement. The tick_end packet (empty container, protocol name "tick_end") has existed in the wire protocol since 1.21.3, but nothing in prismarine land currently sends it. Add a feature flag so client implementations can gate sending it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
maebahesioru
force-pushed
the
feature/client-tick-end-flag
branch
from
October 4, 2026 01:35
0fd7cf3 to
6c548cf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature-only diff, split out from the 26.3 stack per review feedback.
The tick_end packet (empty container, protocol name
tick_end) has existed in the wire protocol since 1.21.3. A client that never sends it gets kicked on its second position-bearing move packet withmultiplayer.disconnect.invalid_player_movementbecause the server only clears its per-tick bookkeeping inhandleClientTickEnd.This PR is just the feature flag (features.json, 8 lines) on top of current master, so it can merge independently of the 26.3 protocol/data work.
Refs: the original stacked branch is DallasCarraher/minecraft-data:pc-26.3-support (PR #1304 was opened from it before the split).