Skip to content

Cleanup CStateManager & friends - #62

Merged
encounter merged 1 commit into
mainfrom
cstatemanager-clean
Aug 13, 2026
Merged

Cleanup CStateManager & friends#62
encounter merged 1 commit into
mainfrom
cstatemanager-clean

Conversation

@encounter

Copy link
Copy Markdown
Member

Had some leftover forward decl and accessor hacks

@decomp-dev

decomp-dev Bot commented Aug 12, 2026

Copy link
Copy Markdown

Report for GM8E01_48 (06aa997 - 9275d07)

No changes

Report for GM8E01_01 (06aa997 - 9275d07)

📈 Matched code: 36.08% (+0.00%, +104 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/MetroidPrime/CStateManager CStateManager::RenderLast(const TUniqueId&) +16 79.74% 100.00%
main/MetroidPrime/CStateManager CWorld::GetAliveAreasEnd() +12 0.00% 100.00%
main/MetroidPrime/CWorld __sinit_CWorld_cpp +4 75.00% 100.00%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CWorld CWorld::TravelToArea(const TAreaId&, CStateManager&, bool) +623 0.00% 92.25%
main/MetroidPrime/CStateManager CStateManager::SetupFogForArea3XRange(const CGameArea&) const +112 0.00% 82.65%
main/MetroidPrime/CStateManager CStateManager::MurderScriptInstanceNames() +12 83.58% 87.70%
main/MetroidPrime/CWorld .sbss +6 40.00% 80.00%
main/MetroidPrime/CStateManager .sdata2 +2 83.33% 84.17%

Report for GM8E01_00 (06aa997 - 9275d07)

📈 Matched code: 37.27% (+0.00%, +104 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/MetroidPrime/CStateManager CStateManager::RenderLast(const TUniqueId&) +16 79.74% 100.00%
main/MetroidPrime/CStateManager CWorld::GetAliveAreasEnd() +12 0.00% 100.00%
main/MetroidPrime/CWorld __sinit_CWorld_cpp +4 75.00% 100.00%
📈 6 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CWorld CWorld::TravelToArea(const TAreaId&, CStateManager&, bool) +623 0.00% 92.25%
main/MetroidPrime/CStateManager CStateManager::SetupFogForArea3XRange(const CGameArea&) const +112 0.00% 82.65%
main/MetroidPrime/CStateManager CStateManager::GetVisSetForArea(TAreaId, TAreaId, CPVSVisSet&) const +23 81.44% 84.07%
main/MetroidPrime/CStateManager CStateManager::MurderScriptInstanceNames() +12 83.58% 87.70%
main/MetroidPrime/CWorld .sbss +6 40.00% 80.00%
main/MetroidPrime/CStateManager .sdata2 +2 83.33% 84.17%

@encounter
encounter merged commit bdf2ee4 into main Aug 13, 2026
6 checks passed
@encounter
encounter deleted the cstatemanager-clean branch August 13, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant