refactor(landing): one WelcomePageContent behind / and /welcome - #381
Merged
Conversation
The two routes duplicated a 30-line hydration skeleton and differed only in whether a logged-in viewer is bounced to /feed. The skeleton and the hydration gate move into the component; the root route passes redirectAuthenticated and /welcome does not, so the sidebar logo can always reach the landing page.
Deploying yappr-v2 with
|
| Latest commit: |
daaddd6
|
| Status: | ⚡️ Build in progress... |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/page.tsxandapp/welcome/page.tsxeach carried the same 30-line hydration skeleton; the only difference was that/redirects a logged-in viewer to/feed. Both are now three-line wrappers.WelcomePageContentowns the hydration gate, the skeleton (LandingSkeleton), and an opt-inredirectAuthenticatedprop that/sets./welcomestays: the sidebar logo links to it so a logged-in user can still see the landing page.Part of the anti-slop cleanup series (after #370–#380).
Test plan
npm run lint(zero warnings),tsc --noEmit,npm run test,npx knip,npm run buildall green locally/logged out shows the landing page;/logged in lands on/feed; sidebar logo →/welcomewhile logged in shows the landing page with "Go to Feed"🤖 Generated with Claude Code