refactor(layout): PageShell and PageHeader behind the three-column frame - #382
Merged
Conversation
Twenty-four pages each carried the same Sidebar / 700px main column / RightSidebar frame (fifty copies counting loading and empty states) and twenty-three carried the same sticky translucent header with the potato-mode blur toggle. components/layout/page-shell.tsx holds both once. Pages that put modals after the frame wrap in a fragment; centred spinner and empty-state frames pass mainClassName; the two headers that own a tab strip pass borderless. Every page that only read potatoMode for the header no longer subscribes to the settings store; FeedHeader drops its potatoMode prop for the same reason. Blog stays on its own wide-mode frame.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The regex conversion skipped this page because its early-return frame has no main column; the full-page return was the canonical 700px frame and belongs on PageShell like the rest.
Deploying yappr-v2 with
|
| Latest commit: |
3b3828f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c57258a.yappr-v2.pages.dev |
| Branch Preview URL: | https://refactor-page-shell.yappr-v2.pages.dev |
Deploying yappr with
|
| Latest commit: |
3b3828f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1aa1adad.yappr.pages.dev |
| Branch Preview URL: | https://refactor-page-shell.yappr.pages.dev |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/layout/page-shell.tsx:PageShell(Sidebar, 700px centre<main>, RightSidebar;mainClassNamefor centred spinner/empty frames,hideRightSidebarfor wide views) andPageHeader(the sticky translucent bar;borderlessfor headers with their own tab strip; reads potato mode itself).FeedHeaderdrops itspotatoModeprop.app/blog/page.tsx(its own wide-mode frame with a different centre column) and the landing page (its own hero layout).Markup is unchanged: the same three
div/mainwrappers with the same classes, and the same header classes.Part of the anti-slop cleanup series (after #370–#381).
Test plan
npm run lint(zero warnings),tsc --noEmit,npm run test,npx knip,npm run buildall green locally🤖 Generated with Claude Code