Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/prenatalppkt/builders/gyn_phenopacket.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def _hpo_resource(hpo_parser: HpoParser) -> pps2.Resource:
def _narrative_feature(term) -> pps2.PhenotypicFeature:
return pps2.PhenotypicFeature(
type=pps2.OntologyClass(id=term.hpo_id, label=term.hpo_label),
excluded=term.excluded,
description="Gyn exam impression",
)

Expand Down
18 changes: 18 additions & 0 deletions tests/builders/test_gyn_phenopacket.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,21 @@ def test_gyn_phenopacket_no_accession_falls_back(hpo_parser, now_ts):

assert pp.subject.id == "patient"
assert pp.id == "gyn-exam"


def test_negated_narrative_finding_marked_excluded(hpo_parser, now_ts):
"""Gwen Sally's impression explicitly documents an ABSENT finding
("No evidence of hydronephrosis"). fenominal correctly flags this
SimpleTerm as excluded=True; the resulting PhenotypicFeature must
carry that same excluded=True rather than silently defaulting to
"observed/present" - same fix as observer_phenopacket.py's and
viewpoint_phenopacket.py's identical bug."""
raw = json.loads((DATA_DIR / "Gwen_Sally_pretty.json").read_text())

pp = build_gyn_phenopacket(raw, hpo_parser, now_ts)

hydronephrosis_features = [
pf for pf in pp.phenotypic_features if pf.type.id == "HP:0000126"
]
assert len(hydronephrosis_features) == 1
assert hydronephrosis_features[0].excluded is True
Loading