Repository navigation
fix: respect SimpleTerm.excluded in gyn_phenopacket's narrative feature - #115
Merged
Merged
Conversation
Same bug already fixed in observer_phenopacket.py and viewpoint_phenopacket.py (PR6/#111), present here too since gyn_phenopacket.py was copied from the same original code before that fix existed. _narrative_feature() never read term.excluded, so fenominal's negation detection was silently dropped. Real fixture (Gwen_Sally_pretty.json) already has a negated finding ("No evidence of hydronephrosis"), so no new fixture needed. Verified the new regression test fails without the fix and passes with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same bug already fixed in observer_phenopacket.py and viewpoint_phenopacket.py (PR6/#111), present here too since gyn_phenopacket.py was copied from the same original code before that fix existed. _narrative_feature() never read term.excluded, so fenominal's negation detection was silently dropped.
Real fixture (Gwen_Sally_pretty.json) already has a negated finding ("No evidence of hydronephrosis"), so no new fixture needed. Verified the new regression test fails without the fix and passes with it.