Skip to content

fw: validate scope inheritance in policies and rules v1 #16122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukashino wants to merge 1 commit into from
Closed

fw: validate scope inheritance in policies and rules v1 #16122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/detect-parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,14 @@ static int SigParseActionDo(const char *action_in, const int idx, const bool fw_
return -1;
}
*scope_out = scope_flags;
} else if (*scope_out != 0 && (flags & (ACTION_DROP | ACTION_PASS))) {
/* No scope given, this action inherits the scope set by the other
* actions of a multi-action rule. */
if (*scope_out != ACTION_SCOPE_PACKET && *scope_out != ACTION_SCOPE_FLOW) {
SCLogError("invalid action scope '%s' in action '%s': only 'packet' and 'flow' allowed",
ActionScopeToString((enum ActionScope) * scope_out), action_in);
return -1;
}
}

/* require explicit action scope for fw rules */
Expand Down
Loading