fw: validate scope inheritance in policies and rules v1 - #16122
Closed
lukashino wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Validates inherited action scopes in firewall multi-action rules and policies.
Changes:
- Rejects
drop/passactions inheriting unsupportedhookortxscopes. - Permits valid inherited
packetandflowscopes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16122 +/- ##
==========================================
- Coverage 83.06% 83.04% -0.02%
==========================================
Files 1004 1004
Lines 277376 277381 +5
==========================================
- Hits 230389 230348 -41
- Misses 46987 47033 +46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 33378 |
lukashino
marked this pull request as ready for review
August 26, 2026 17:11
Contributor
Author
|
continues in #16132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8954
Describe changes:
SV_BRANCH=OISF/suricata-verify#3323