Detect count 5044 v4.1 - #15299
Closed
catenacyber wants to merge 5 commits into
Closed
Conversation
Also rename parse_uint_count as parse_multi_count This allows to prepare multi-buffers using this code
As for multi-integers, multi-buffers can now have the following arguments - nb - precise index - all Ticket: 5044
Ticket: 5044
- or_absent can also be any_or_absent - nb can also be matches - precise index can have prefix index
victorjulien
reviewed
May 1, 2026
| ============= =========================================================== | ||
| Value Description | ||
| ============= =========================================================== | ||
| [default] Match with any index |
Member
There was a problem hiding this comment.
suggest adding something like
(same as `index <value>`)
victorjulien
reviewed
May 1, 2026
| ============= =========================================================== | ||
| [default] Match with any index | ||
| any Match with any index | ||
| or_absent Match with any index or matches on an empty list |
Member
There was a problem hiding this comment.
should this be any_or_absent for clarity?
Contributor
Author
There was a problem hiding this comment.
ok (both work in the code)
Contributor
Author
|
Replaced by #15302 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15299 +/- ##
==========================================
- Coverage 82.65% 82.64% -0.02%
==========================================
Files 993 994 +1
Lines 270997 271185 +188
==========================================
+ Hits 223985 224111 +126
- Misses 47012 47074 +62
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5044
Describe changes:
all,all_or_absent,matches`, and precise indexingSV_BRANCH=OISF/suricata-verify#3062
Draft : I would like some approval before doing all the individual modifications for each multi-buffer
#15100 next without count but
buffer: all; sid: 1without content for buffers/==NULL/!=NULL/that led to uaf)TODOs :
countsupport