Detect count 5044 v3.4 - #15100
Closed
catenacyber wants to merge 4 commits into
Closed
Conversation
Also rename parse_uint_count as parse_multi_count This allows to prepare multi-buffers using this code
As for multi-integers, multi-buffers can now have the following arguments - count - nb - precise index - all Ticket: 5044
Ticket: 5044
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15100 +/- ##
==========================================
- Coverage 82.63% 82.59% -0.04%
==========================================
Files 990 991 +1
Lines 271599 271824 +225
==========================================
+ Hits 224429 224523 +94
- Misses 47170 47301 +131
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 30537 |
| "all" => Some(DetectUintIndex::All), | ||
| "all_or_absent" => Some(DetectUintIndex::AllOrAbsent), | ||
| "any" => Some(DetectUintIndex::Any), | ||
| "absent_or" => Some(DetectUintIndex::OrAbsent), |
Contributor
Author
There was a problem hiding this comment.
added any_or_absent syntax sugar
| return false; | ||
| } | ||
|
|
||
| if (idx == DETECT_COUNT_INDEX) { |
Member
There was a problem hiding this comment.
as discussed in Salzburg, we want a form of a GetBufferCount callback instead
Contributor
Author
There was a problem hiding this comment.
Agreed, leaving that out to already get an approval for the rest
Contributor
Author
|
Replaced by #15299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5044
Describe changes:
countoption to multi-buffers, behaving like a keyword but syntax isemail.received: count <3;all,all_or_absent,nb`, and precise indexingSV_BRANCH=OISF/suricata-verify#2634
Draft :
#14346 needed rebase
TODOs :