tests: add test for bug 8856 - #3302
Open
victorjulien wants to merge 1 commit into
Open
Conversation
Collaborator
|
Why is CI green ? |
Member
Author
It only triggers on an ASAN enabled build. |
Member
We do build Suricata on ubuntu-24 job with ASAN. |
Collaborator
|
I do not reproduce locally with ASAN on macOS |
Member
Author
|
Must have been mixing things up. I can't either, and neither with valgrind. |
victorjulien
force-pushed
the
pppoe-8856/v2
branch
from
August 25, 2026 12:49
eef924b to
58ab861
Compare
Test reproduces DecodePPPOESession over-read with 7-byte PPPoE session header and non-zero pppoe_length. Verifies decoder.event.pppoe.pkt_too_small stat is raised. The test won't fail on the branches w/o the fix, as the overread is always in a larger block of memory and has no side effects. Ticket: #8856.
victorjulien
force-pushed
the
pppoe-8856/v2
branch
from
August 25, 2026 12:50
58ab861 to
434129d
Compare
Member
Author
|
So this doesn't trigger the bug but it's still useful to have a test for this small packet condition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test reproduces DecodePPPOESession over-read with 7-byte PPPoE session header and non-zero pppoe_length. Verifies decoder.event.pppoe.pkt_too_small stat is raised.
Ticket: #8856.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/