pppoe: fix session over-read in DecodePPPOESession - #16083
Closed
victorjulien wants to merge 1 commit into
Closed
Conversation
|
Information: QA ran without warnings. Pipeline = 33245 |
Prevent out-of-bounds read of protocol field when PPPoE session header is exactly PPPOE_SESSION_HEADER_MIN_LEN (7) bytes. Inspect first protocol octet only to decide single vs double octet form, and read second octet only after len >= 8 verification. Ticket: OISF#8856.
victorjulien
force-pushed
the
pppoe-8856/v1
branch
from
August 23, 2026 17:29
6b04267 to
44546f3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16083 +/- ##
==========================================
- Coverage 83.04% 83.02% -0.02%
==========================================
Files 1004 1004
Lines 277359 277362 +3
==========================================
- Hits 230322 230279 -43
- Misses 47037 47083 +46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 33249 |
victorjulien
marked this pull request as ready for review
August 23, 2026 19:33
Member
Author
|
Replaced by #16102. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent out-of-bounds read of protocol field when PPPoE session header is exactly PPPOE_SESSION_HEADER_MIN_LEN (7) bytes. Inspect first protocol octet only to decide single vs double octet form, and read second octet only after len >= 8 verification.
Ticket: #8856.
https://redmine.openinfosecfoundation.org/issues/8856
SV_BRANCH=OISF/suricata-verify#3302