Skip to content

fix: catch FileExistsError when checkpointing to distributed fs #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoumpa merged 1 commit into from
Aug 28, 2026
+6 −1
Merged

fix: catch FileExistsError when checkpointing to distributed fs #3686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nemo_automodel/components/checkpoint/checkpointing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,7 +2028,12 @@ def _create_dirs(*dirs: str | None) -> None:
"""Create local directory paths and ignore cloud paths."""
for directory in dirs:
if directory and not is_cloud_path(directory):
os.makedirs(directory, exist_ok=True)
try:
os.makedirs(directory, exist_ok=True)
except FileExistsError:
# virtiofs & co.: a racing rank's mkdir can surface as EEXIST while isdir() lags
if not os.path.isdir(directory):
raise


def _ensure_dirs(*dirs: str | None, process_group: torch.distributed.ProcessGroup | None = None) -> None:
Expand Down
Loading