fix: catch FileExistsError when checkpointing to distributed fs - #3686
Merged
Conversation
Contributor
|
/ok to test 8fb2c5c |
akoumpa
approved these changes
Aug 26, 2026
akoumpa
enabled auto-merge (squash)
August 26, 2026 16:41
akoumpa
disabled auto-merge
August 28, 2026 05:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes spurious racey FileExistsErrors when creating directories for checkpointing.
This can happen on distributed filesystems (virtiofs in my case).
A multi-hour distributed run was killed at step 297/300, leaving other ranks hung, by
Changelog
FileExistsErrors in_create_dirs.Before your PR is "Ready for review"
Pre checks:
Additional Information