Skip to content
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions _maps/map_files/generic/CentCom_oculis.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -11646,7 +11646,10 @@
dir = 6
},
/obj/structure/table/wood,
/obj/machinery/fax/auto_name,
/obj/machinery/fax/castor{
dir = 1;
fax_id = "castor_psych"
},
/turf/open/floor/wood,
/area/centcom/castor/psychologist)
"hFu" = (
Expand Down Expand Up @@ -13093,9 +13096,9 @@
/area/centcom/interlink)
"jfO" = (
/obj/structure/table/wood,
/obj/machinery/fax/auto_name{
/obj/machinery/fax/castor{
dir = 1;
name = "Sectorial Internal Affairs Administrator's Office's Fax Machine"
fax_id = "castor_SIAA"
},
/turf/open/floor/wood,
/area/centcom/castor/sectorial_internal_affairs_administrator)
Expand Down Expand Up @@ -15135,9 +15138,9 @@
/area/centcom/holding/cafe)
"lim" = (
/obj/structure/table/wood/fancy/green,
/obj/machinery/fax/auto_name{
/obj/machinery/fax/castor{
dir = 1;
name = "Sectorial Personnel Administrator's Office's Fax Machine"
fax_id = "castor_SPA"
},
/turf/open/floor/carpet/green{
initial_gas_mix = "o2=21.65;n2=80.7;TEMP=287.53"
Expand Down Expand Up @@ -21147,7 +21150,10 @@
/turf/open/floor/iron/dark/pattern_1,
/area/centcom/central_command_areas/hallway)
"qKa" = (
/obj/machinery/fax/auto_name,
/obj/machinery/fax/castor{
dir = 1;
fax_id = "castor_intern"
},
/obj/structure/table/reinforced/plastitaniumglass,
/turf/open/floor/carpet/black,
/area/centcom/castor/intern_office)
Expand Down Expand Up @@ -23651,9 +23657,9 @@
dir = 6
},
/obj/structure/sign/flag/nanotrasen/directional/east,
/obj/machinery/fax/auto_name{
/obj/machinery/fax/castor{
dir = 1;
name = "Sectorial Security Administrator's Office's Fax Machine"
fax_id = "castor_SSA"
},
/turf/open/floor/carpet/royalblack,
/area/centcom/castor/sectorial_security_administrator)
Expand Down Expand Up @@ -26180,9 +26186,9 @@
/obj/effect/turf_decal/siding/thinplating_new/light{
dir = 1
},
/obj/machinery/fax/auto_name{
/obj/machinery/fax/castor{
dir = 1;
name = "Sectorial Medical Administrator's Office's Fax Machine"
fax_id = "castor_SMA"
},
/turf/open/floor/carpet/cyan,
/area/centcom/castor/sectorial_medical_administrator)
Expand Down Expand Up @@ -26472,9 +26478,9 @@
/area/centcom/interlink)
"vKx" = (
/obj/structure/table/reinforced,
/obj/machinery/fax/auto_name{
/obj/machinery/fax/castor{
dir = 1;
name = "Sectorial Engineering Administrator's Office's Fax Machine"
fax_id = "castor_SEA"
},
/turf/open/floor/iron/dark/smooth_large,
/area/centcom/castor/sectorial_engineering_administrator)
Expand Down
4 changes: 2 additions & 2 deletions code/modules/admin/admin_fax_panel.dm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change.

Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ ADMIN_VERB(fax_panel, R_ADMIN, "Fax Panel", "View and respond to faxes sent to C
/datum/fax_panel_interface/New()
//Get all faxes, and save them to our list.
for(var/obj/machinery/fax/fax as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax))
if(istype(fax, /obj/machinery/fax/admin))
continue
// if(istype(fax, /obj/machinery/fax/admin)) // OCULIS REMOVAL - may as well be able to send to admin faxes in case that's relevant, right?
// continue // OCULIS REMOVAL
available_faxes += WEAKREF(fax)

//Get all stamps
Expand Down
2 changes: 1 addition & 1 deletion code/modules/admin/topic.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1440,7 +1440,7 @@
if(!check_rights(R_ADMIN))
return

for(var/obj/machinery/fax/admin/FAX as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin))
for(var/obj/machinery/fax/FAX as anything in (SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin) + SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/castor))) // OCULIS EDIT, ORIGINAL: for(var/obj/machinery/fax/admin/FAX as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin))
if(FAX.fax_id != href_list["destination"])
continue
FAX.receive(locate(href_list["print_fax"]), href_list["sender_name"])
Expand Down
15 changes: 13 additions & 2 deletions code/modules/paperwork/fax.dm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use modular files instead of editing the TG ones for this.

Original file line number Diff line number Diff line change
Expand Up @@ -323,17 +323,28 @@ GLOBAL_VAR_INIT(fax_autoprinting, FALSE)

history_add("Send", params["name"])

// OCULIS ADDITION START
var/notice_text = "[icon2html(src.icon, GLOB.admins)]<b><font color=green>FAX REQUEST: </font>[ADMIN_FULLMONTY(usr)]:</b> [span_linkify("sent a fax message from [fax_name]/[fax_id][ADMIN_FLW(src)] to [html_encode(params["name"])]")] [ADMIN_SHOW_PAPER(fax_paper)] [ADMIN_PRINT_FAX(fax_paper, fax_name, params["id"])]"
// Find the machine if it exists so we can give the admins a FLW to it
var/fax_machine_types = SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin) + SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/castor)
for(var/obj/machinery/fax/FAX as anything in fax_machine_types)
if(FAX.fax_id != params["id"])
continue
notice_text += " [ADMIN_FLW(FAX)]"
break
// OCULIS ADDITION END

GLOB.requests.fax_request(usr.client, "sent a fax message from [fax_name]/[fax_id] to [params["name"]]", list("paper" = fax_paper, "destination_id" = params["id"], "sender_name" = fax_name))
to_chat(GLOB.admins,
span_adminnotice("[icon2html(src.icon, GLOB.admins)]<b><font color=green>FAX REQUEST: </font>[ADMIN_FULLMONTY(usr)]:</b> [span_linkify("sent a fax message from [fax_name]/[fax_id][ADMIN_FLW(src)] to [html_encode(params["name"])]")] [ADMIN_SHOW_PAPER(fax_paper)] [ADMIN_PRINT_FAX(fax_paper, fax_name, params["id"])]"),
span_adminnotice(notice_text), // OCULIS EDIT, ORIGINAL: span_adminnotice("[icon2html(src.icon, GLOB.admins)]<b><font color=green>FAX REQUEST: </font>[ADMIN_FULLMONTY(usr)]:</b> [span_linkify("sent a fax message from [fax_name]/[fax_id][ADMIN_FLW(src)] to [html_encode(params["name"])]")] [ADMIN_SHOW_PAPER(fax_paper)] [ADMIN_PRINT_FAX(fax_paper, fax_name, params["id"])]"),
type = MESSAGE_TYPE_PRAYER,
confidential = TRUE)
for(var/client/staff as anything in GLOB.admins)
if(staff?.prefs.read_preference(/datum/preference/toggle/comms_notification))
SEND_SOUND(staff, sound('modular_oculis/modules/fax_sound/sound/fax.ogg')) // OCULIS EDIT, ORIGINAL: SEND_SOUND(staff, sound('sound/misc/server-ready.ogg'))

if(GLOB.fax_autoprinting)
for(var/obj/machinery/fax/admin/FAX as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin))
for(var/obj/machinery/fax/FAX as anything in fax_machine_types) // OCULIS EDIT, ORIGINAL: for(var/obj/machinery/fax/admin/FAX as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin)
if(FAX.fax_id != params["id"])
continue
FAX.receive(fax_paper, fax_name)
Expand Down
23 changes: 21 additions & 2 deletions code/modules/requests/request_manager.dm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admins can already follow faxes via the fax menu.

Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,19 @@ GLOBAL_DATUM_INIT(requests, /datum/request_manager, new)
if (request.req_type != REQUEST_FAX)
to_chat(usr, "Request doesn't have a paper to print.", confidential = TRUE)
return TRUE
for(var/obj/machinery/fax/admin/FAX as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin))
var/fax_machine_found = FALSE // OCULIS ADDITION
for(var/obj/machinery/fax/FAX as anything in (SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin) + SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/castor))) // OCULIS EDIT, ORIGINAL: for(var/obj/machinery/fax/admin/FAX as anything in SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin))
if(FAX.fax_id != request.additional_information["destination_id"])
continue
fax_machine_found = TRUE // OCULIS ADDITION
var/obj/item/paper/request_message = request.additional_information["paper"]
var/sender_name = request.additional_information["sender_name"]
FAX.receive(request_message, sender_name)
return TRUE
// OCULIS ADDITION START
if(!fax_machine_found)
to_chat(usr, "Fax machine doesn't exist.", confidential = TRUE)
// OCULIS ADDITION END
return TRUE // OCULIS EDIT - decreased indentation by one tab from original
if ("play")
if(request.req_type != REQUEST_INTERNET_SOUND)
to_chat(usr, "Request doesn't have a sound to play.", confidential = TRUE)
Expand All @@ -261,6 +267,19 @@ GLOBAL_DATUM_INIT(requests, /datum/request_manager, new)
web_sound(usr, request.message)
// OCULIS EDIT ADDITION END
return TRUE
// OCULIS ADDITION START: fax_flw
if("fax_flw")
var/fax_machine_found = FALSE
for(var/obj/machinery/fax/FAX as anything in (SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/admin) + SSmachines.get_machines_by_type_and_subtypes(/obj/machinery/fax/castor)))
if(FAX.fax_id != request.additional_information["destination_id"])
continue
fax_machine_found = TRUE
usr.client.admin_follow(FAX)
break
if(!fax_machine_found)
to_chat(usr, "Fax machine doesn't exist.", confidential = TRUE)
return TRUE
// OCULIS ADDITION END: fax_flw

/datum/request_manager/ui_data(mob/user)
var/list/data = list()
Expand Down
23 changes: 23 additions & 0 deletions modular_oculis/master_files/code/modules/paperwork/fax.dm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The castor fax machines do not need their own special network. Surely there's a better way to do this?

Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/obj/machinery/fax/Initialize(mapload)
special_networks += list(
castor_psych = list(fax_name = "Castor Psychologist's Office", fax_id = "castor_psych", color = "green", emag_needed = FALSE),
castor_intern = list(fax_name = "Castor Intern's Office", fax_id = "castor_intern", color = "green", emag_needed = FALSE),
castor_SC = list(fax_name = "Sectorial Commander's Office", fax_id = "castor_SC", color = "green", emag_needed = FALSE),
castor_SPA = list(fax_name = "Sectorial Personnel Administrator's Office", fax_id = "castor_SPA", color = "green", emag_needed = FALSE),
castor_SSA = list(fax_name = "Sectorial Security Administrator's Office", fax_id = "castor_SSA", color = "green", emag_needed = FALSE),
castor_SRA = list(fax_name = "Sectorial Research Administrator's Office", fax_id = "castor_SRA", color = "green", emag_needed = FALSE),
castor_SMA = list(fax_name = "Sectorial Medical Administrator's Office", fax_id = "castor_SMA", color = "green", emag_needed = FALSE),
castor_SLA = list(fax_name = "Sectorial Logistics Administrator's Office", fax_id = "castor_SLA", color = "green", emag_needed = FALSE),
castor_SEA = list(fax_name = "Sectorial Engineering Administrator's Office", fax_id = "castor_SEA", color = "green", emag_needed = FALSE),
castor_SIAA = list(fax_name = "Sectorial Internal Affairs Administrator's Office", fax_id = "castor_SIAA", color = "green", emag_needed = FALSE),
)
return ..()

// Separate from the /admin type, to not collide with the conficting init. Requires a fax_id specified when mapping!
Comment thread
Shroopy marked this conversation as resolved.
/obj/machinery/fax/castor
name = "Castor Fax Machine"

/obj/machinery/fax/castor/Initialize(mapload)
. = ..()
fax_name = special_networks[fax_id]["fax_name"]

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Alternate Tests / run (516, 1648, runtimestation) / Run Tests (516.1648; runtimestation; 516)

Runtime Station: /datum/unit_test/create_and_destroy

[13:32:39] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,7) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,7) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (tramstation) / Run Tests (tramstation; 516)

Tramstation: /datum/unit_test/create_and_destroy

[13:37:32] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,14) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,14) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (oceanpubby) / Run Tests (oceanpubby; 516)

Pubby Station: /datum/unit_test/create_and_destroy

[13:34:29] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,5) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,5) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (voidraptor) / Run Tests (voidraptor; 516)

Void Raptor: /datum/unit_test/create_and_destroy

[13:37:15] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,13) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,13) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (gateway_test) / Run Tests (gateway_test; 516)

Gateway Test: /datum/unit_test/create_and_destroy

[13:34:55] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,15) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,15) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (metastation) / Run Tests (metastation; 516)

MetaStation: /datum/unit_test/create_and_destroy

[13:34:13] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,13) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,13) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (kilostation_oculis) / Run Tests (kilostation_oculis; 516)

Kilo Station: /datum/unit_test/create_and_destroy

[13:35:59] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,13) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,13) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (remorastation) / Run Tests (remorastation; 516)

NTSS Remora: /datum/unit_test/create_and_destroy

[13:35:30] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,12) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,12) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (serenitystation) / Run Tests (serenitystation; 516)

SerenityStation: /datum/unit_test/create_and_destroy

[13:34:33] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,7) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,7) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (multiz_debug) / Run Tests (multiz_debug; 516)

MultiZ Debug: /datum/unit_test/create_and_destroy

[13:36:30] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,15) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,15) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()

Check failure on line 22 in modular_oculis/master_files/code/modules/paperwork/fax.dm

View workflow job for this annotation

GitHub Actions / Integration Tests / run (runtimestation) / Run Tests (runtimestation; 516)

Runtime Station: /datum/unit_test/create_and_destroy

[13:34:29] Runtime in modular_oculis/master_files/code/modules/paperwork/fax.dm,22: bad index proc name: Initialize (/obj/machinery/fax/castor/Initialize) src: Castor Fax Machine (/obj/machinery/fax/castor) src.loc: the floor (126,126,7) (/turf/open/floor/iron) call stack: Castor Fax Machine (/obj/machinery/fax/castor): Initialize(0, null) Atoms (/datum/controller/subsystem/atoms): InitAtom(Castor Fax Machine (/obj/machinery/fax/castor), 0, /list (/list)) Castor Fax Machine (/obj/machinery/fax/castor): New(0, null) Castor Fax Machine (/obj/machinery/fax/castor): New(the floor (126,126,7) (/turf/open/floor/iron), null) /datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run() RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list)) RunUnitTests() /datum/callback (/datum/callback): InvokeAsync()
name = "[fax_name]'s Fax Machine"
1 change: 1 addition & 0 deletions tgstation.dme
Original file line number Diff line number Diff line change
Expand Up @@ -10062,6 +10062,7 @@
#include "modular_oculis\master_files\code\modules\mob\living\navigation.dm"
#include "modular_oculis\master_files\code\modules\mob\living\basic\lavaland\raptor\_raptor.dm"
#include "modular_oculis\master_files\code\modules\mocking\client.dm"
#include "modular_oculis\master_files\code\modules\paperwork\fax.dm"
#include "modular_oculis\master_files\code\modules\projectiles\gun.dm"
#include "modular_oculis\master_files\code\modules\projectiles\projectile_speed.dm"
#include "modular_oculis\master_files\code\modules\projectiles\boxes_magazines\ammo_boxes.dm"
Expand Down
5 changes: 5 additions & 0 deletions tgui/packages/tgui/interfaces/RequestManager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ const RequestControls = (props) => {
<Button onClick={() => act('print', { id: request.id })}>
PRINT
</Button>
{/* OCULIS ADDITION START */}
<Button onClick={() => act('fax_flw', { id: request.id })}>
FAX FLW
</Button>
{/* OCULIS ADDITION END */}
</>
)}
{request.req_type === 'request_internet_sound' && (
Expand Down
Loading