Admin fax changes#279
Conversation
|
I made the castor faxes not a subtype of admin faxes because I didn't want to touch the admin fax initialization for multiple reasons and couldn't figure out how to implement a subtype without doing that, but I'm not sure using a new type was the best choice. I could use advice about that. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~14 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the Oculis Station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
|
This should be ready, unless there's bugs with it I'm unaware of. |
There was a problem hiding this comment.
Please undo this change.
There was a problem hiding this comment.
Please use modular files instead of editing the TG ones for this.
There was a problem hiding this comment.
Admins can already follow faxes via the fax menu.
There was a problem hiding this comment.
The castor fax machines do not need their own special network. Surely there's a better way to do this?
2 participants
About The Pull Request
Changes the fax machines on Castor (aka CentCom aka the Interlink) to be part of the special_networks list, which makes the request manager intercept faxes to them and ping admins.
Allows the admin fax panel to send to admin fax machines.
Adds an ADMIN_FLW to the admin fax notice when the fax machine exists, and a similar button to request manager that throws an error if the fax machine doesn't, to jump to the relevant fax machine.
Why it's Good for the Game
Admins won't miss faxes sent to machines other than the Sectorial Command machine but meant for them now.
Preventing the fax panel from sending to admin fax machines is an unnecessary restriction and could be useful.
Being able to jump to a fax machine that received a message is useful, especially if autoprinting is on.
Proof of Testing
Screenshots/Videos
Print working on the non-Sectorial Command fax:
Changelog
🆑
admin: Castor's fax machines are now intercepted by the request manager and ping admins.
admin: The fax panel can now send to admin fax machines.
admin: Fax notices now have a FLW button to jump to the receiving fax machine, when the fax machine exists. The request manager now has a FAX FLW button for fax requests to attempt to jump to the receiving fax machine, if it exists.
/:cl: