Fix LCE constantly ticking when it has fuel but no lubricant - #5356
Open
DilithiumThoride wants to merge 2 commits into
Open
Fix LCE constantly ticking when it has fuel but no lubricant#5356DilithiumThoride wants to merge 2 commits into
DilithiumThoride wants to merge 2 commits into
Conversation
DilithiumThoride
added
type: bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While testing #5355 I accidentally stumbled upon another issue:
If a Large Combustion Engine contains Fuel but no Lubricant, it will try to start a recipe every tick, fail every tick, and send a sync packet every tick of the failed recipe start.
There is no reason for an LCE to keep trying to run when it can't, so this PR makes a fueled LCE stop ticking and sit fully idle until Notified it should try again. The LCE reports to the user that it is idle because it has no lubricant.
Implementation Details
Custom minimal internal RecipeLogic whose sole purpose is to check if the last recipe attempt failed due to no lubricant, and if it did to unsubscribe the ticker.
AI Usage
Outcome
Unlubricated LCEs stop draining ticks and packets and only wake up when notified they can actually try to turn on again.
How Was This Tested
Creative test world