Skip to content

Fix Adv Fluid Void copy/pasting wrong and having its void limit clamped #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DilithiumThoride wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from
Open

Fix Adv Fluid Void copy/pasting wrong and having its void limit clamped #5325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f55331
Fix Adv Fluid Void copy/pasting wrong and having its void limit clamped
DilithiumThoride Aug 21, 2026
1fad4a5
Merge branch '1.20.1' into dt/void-cleanup
DilithiumThoride Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/main/java/com/gregtechceu/gtceu/common/cover/voiding/AdvancedFluidVoidingCover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
@ParametersAreNonnullByDefault
public class AdvancedFluidVoidingCover extends FluidVoidingCover {

private static final int MAX_STACK_SIZE = 2_048_000_000; // Capacity of quantum tank IX

@SaveField
@SyncToClient
@Getter
Expand Down Expand Up @@ -136,19 +138,10 @@ public void createCoverUIRows(Flow column, SidedPosGuiData data, PanelSyncManage

column.child(
GTMuiWidgets
.createIntInputWithBucketMode(voidingLimit, bucketModeSync, () -> getVoidingMode().maxStackSize)
.createIntInputWithBucketMode(voidingLimit, bucketModeSync, () -> MAX_STACK_SIZE)

@jurrejelle jurrejelle Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do () -> Integer.MAX_VALUE here, incase someone makes a tank with a size bigger than our quantum tank IX.

.setEnabledIf($ -> shouldShowStackSize()));
}

private int getCurrentBucketModeTransferSize() {
return this.globalTransferSizeMillibuckets / this.transferBucketMode.multiplier;
}

private void setCurrentBucketModeTransferSize(int transferSize) {
this.globalTransferSizeMillibuckets = Math.max(transferSize * this.transferBucketMode.multiplier, 0);
syncDataHolder.markClientSyncFieldDirty("globalTransferSizeMillibuckets");
}

private boolean shouldShowStackSize() {
if (this.voidingMode == VoidingMode.VOID_ANY)
return false;
Expand All @@ -170,7 +163,7 @@ public void copyConfig(CompoundTag tag) {
public void pasteConfig(ServerPlayer player, CompoundTag tag) {
setVoidingMode(VoidingMode.values()[tag.getInt("voidingMode")]);
setTransferBucketMode(BucketMode.values()[tag.getInt("voidBucketMode")]);
setCurrentBucketModeTransferSize(tag.getInt("voidSize"));
setGlobalTransferSizeMillibuckets(tag.getInt("voidSize"));
super.pasteConfig(player, tag);
}
}
Loading