Skip to content

Update shaka-player error URL #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FreeTubeBot merged 3 commits into from
Sep 27, 2026
Merged

Update shaka-player error URL #9828

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aabbb59
Update shaka-player error URL and add JSON.stringify to objects
absidue Sep 21, 2026
f830db2
URL encode the colon in the URL
absidue Sep 22, 2026
cfe9e3e
Remove outdated comment
absidue Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/renderer/helpers/player/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import shaka from 'shaka-player'
import { deepCopy } from '../utils'
import i18n from '../../i18n/index'
import { sponsorBlockSkipSegments } from '../sponsorblock'

Expand All @@ -26,7 +25,7 @@ export function logShakaError(error, context, videoId, details) {
const codeText = Object.keys(Code).find((/** @type {keyof Code} */ key) => Code[key] === error.code)

const message =
'Player Error (category and code explainations here: https://shaka-player-demo.appspot.com/docs/api/shaka.util.Error.html)\n' +
`Player Error (category and code explainations here: https://shaka-project.github.io/shaka-player/docs/api/shaka.util.Error.html#value%3A${error.code})\n` +
`Video ID: "${videoId}"\n` +
`FreeTube player context: "${context}"\n\n` +
`Severity: ${severityText} (${error.severity})\n` +
Expand All @@ -40,7 +39,7 @@ export function logShakaError(error, context, videoId, details) {
if (error.data && error.data.length > 0) {
args.push(
'\n\nshaka-player Data:',
error.data
JSON.stringify(error.data)
)
}

Expand All @@ -50,7 +49,7 @@ export function logShakaError(error, context, videoId, details) {
// use deepCopy to get rid of Vue's proxying,
// as that requires you click the 3 dots for every property in the logged object to see their values
// doing it like this, results in a "clean" object where everything is immediately visible
Comment thread
absidue marked this conversation as resolved.
Outdated
typeof details === 'object' ? deepCopy(details) : details
typeof details === 'object' ? JSON.stringify(details) : details
)
}

Expand Down
Loading