Update shaka-player error URL - #9828
Merged
Merged
Conversation
github-actions
Bot
added
the
PR: waiting for review
FreeTubeBot
enabled auto-merge (squash)
September 21, 2026 21:45
absidue
force-pushed
the
shaka-error-url
branch
2 times, most recently
from
September 21, 2026 21:50
3274ea2 to
f0c2618
Compare
absidue
force-pushed
the
shaka-error-url
branch
from
September 21, 2026 21:50
f0c2618 to
aabbb59
Compare
radmorecameron
previously approved these changes
Sep 21, 2026
PikachuEXE
reviewed
Sep 21, 2026
Co-authored-by: PikachuEXE <git@pikachuexe.net>
absidue
requested review from
PikachuEXE,
Shadorc,
caetano-dev,
efb4f5ff-1298-471a-8973-3d47447115dc,
ozrendev and
radmorecameron
September 22, 2026 10:41
PikachuEXE
previously approved these changes
Sep 23, 2026
ozrendev
previously approved these changes
Sep 24, 2026
PikachuEXE
approved these changes
Sep 24, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 25, 2026
radmorecameron
approved these changes
Sep 27, 2026
github-actions
Bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
The shaka-player project moved their documentation from Google App Engine to GitHub pages a few months ago and the app spot URLs now redirect to the GitHub pages site. This pull request updates our in-app error messages to point to the new URL and also adds anchors for the error codes so that browers scroll to the correct one automatically.
While I was changing that area of the code I also added JSON.stringify to the shaka-player and FreeTube data sections as most users don't bother expanding those objects when report errors, so this this should hopefully make users' screenshots more useful to us.
Testing
Force a shaka-player error or just manually open the URL in your brower and confirm that it works.
Desktop