Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## e2e-disk-changes #686 +/- ##
===================================================
Coverage 99.67% 99.67%
Complexity 1900 1900
===================================================
Files 135 135
Lines 4873 4873
===================================================
Hits 4857 4857
Misses 16 16 ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Firehed
added this pull request to stack #688
October 4, 2026 01:49
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #685.
Moves the signature help and hover suites onto the end-to-end tier.
Request steps
HoverchecksShows(...)andHides(...), fragments of the content,Formatted(MarkupKind), andNoAnswer().HoverContentdecodes theMarkupContentform this server sends.SignatureHelpchecks the active signature:SignatureShows(...)andDocumentationShows(...), fragments of the label and documentation, andActiveParameter(index); plusSignatureCount(n)andNoAnswer()on the whole answer.SignatureHelpResultdecodes the answer with the protocol's defaults for the active signature and parameter.Scripts
array_mapsignature help, and hover onsort,ArrayObject::getArrayCopy,Exception::$message, andDateTime::getTimestampthroughcloneand??. Their full answers were identical on PHP 8.4, 8.5, and 8.6 in CI. The README now allows a built-in in a script when its output is the same on every version in the matrix, instead of keeping built-ins out.ClientCapabilitiescan declare markdown hover support (textDocument.hover.contentFormat). One script intranscripts/expects a markdown answer and locks its fenced format. Nothing exercised markdown hover before.EdgeCases/HoverInComment.php.Unit tests
ExpressionResolutionTestcovers the paths only the hover suite reached:@return User[]docblock: through auseimport, fully qualified, naming no known class, and with no element type;clonekeeping the copied type;??resolving through its left side.The tests stub the symbol source and type source with only what each case needs.
Originals
HoverHandlerIntegrationTestandSignatureHelpHandlerIntegrationTestare removed.Coverage: unchanged, file by file.
Noted, not changed
A single-line docblock (
/** Text. */) reaches hover and signature help documentation with its closing*/, for example "Static method documentation. */". The expectations check fragments, so they hold whether or not this is fixed. Tracked in #689.🤖 Generated with Claude Code