Skip to content

Move two member completion tests to the end-to-end tier - #687

Draft
Firehed wants to merge 7 commits into
e2e-hover-signature-helpfrom
e2e-completion-poc
Draft

Firehed wants to merge 7 commits into
e2e-hover-signature-helpfrom
e2e-completion-poc

Conversation

@Firehed

@Firehed Firehed commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

Stacked on #686.

A proof of concept for moving member completion onto the end-to-end tier, with two cases from CompletionHandlerIntegrationTest:

  • $this-> in a class with a three-level ancestry offers its own members and every ancestor's.
  • Static access from an unrelated class offers only public static members.

Each script's Offers and Withholds expectations are the original's assertions, label for label.

The two original tests are removed, so this shows a migration end to end. Coverage is unchanged, file by file. The rest of the completion suite is not moved here.

🤖 Generated with Claude Code

Firehed and others added 2 commits October 3, 2026 17:56
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.67%. Comparing base (9ea8e79) to head (ea4e1d5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             e2e-hover-signature-help     #687   +/-   ##
===========================================================
  Coverage                       99.67%   99.67%           
  Complexity                       1900     1900           
===========================================================
  Files                             135      135           
  Lines                            4873     4873           
===========================================================
  Hits                             4857     4857           
  Misses                             16       16           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Firehed
Firehed added this pull request to stack #688 October 4, 2026 01:49
Firehed and others added 5 commits October 3, 2026 18:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant