Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## e2e-hover-signature-help #687 +/- ##
===========================================================
Coverage 99.67% 99.67%
Complexity 1900 1900
===========================================================
Files 135 135
Lines 4873 4873
===========================================================
Hits 4857 4857
Misses 16 16 ☔ View full report in Codecov by Harness. |
Firehed
added this pull request to stack #688
October 4, 2026 01:49
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #686.
A proof of concept for moving member completion onto the end-to-end tier, with two cases from
CompletionHandlerIntegrationTest:$this->in a class with a three-level ancestry offers its own members and every ancestor's.Each script's
OffersandWithholdsexpectations are the original's assertions, label for label.The two original tests are removed, so this shows a migration end to end. Coverage is unchanged, file by file. The rest of the completion suite is not moved here.
🤖 Generated with Claude Code