Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 18:40
5d5db4b to
7dd557a
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 20:39
7dd557a to
fba239c
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 20:43
fba239c to
ae97122
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 20:47
ae97122 to
907a292
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
2 times, most recently
from
October 8, 2026 21:59
a871400 to
e5c1943
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 22:46
e5c1943 to
e84203d
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 22:56
e84203d to
31a6847
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 23:09
31a6847 to
a8fe4f1
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 8, 2026 23:41
a8fe4f1 to
f70aeed
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 9, 2026 00:01
f70aeed to
f5cb8c8
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 9, 2026 01:04
f5cb8c8 to
c63907a
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791482811-grid-lanes-alignment
branch
from
October 11, 2026 10:00
c63907a to
dad1597
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Stacking-axis alignment for Grid Lanes (css-grid-3 §6.3 and §6.4), stacked on #1274. Baselines are out of scope: baseline alignment in the stacking axis falls back to
start, which is what the spec does (§6.5).align-content/justify-contentin the stacking axis moves the stacking range as a whole.centerand the distributed values fall back tocenter/startper the spec,endpacks to the end edge,normal/stretchbehave asstart, andsafeclamps the free space at zero.GetAvailableAlignmentSpaceForItem). Dense-packed items take the space below them in the opening and cut the space of the item above.normalself-alignment behaves asstartin the stacking axis (Chrome 151 does not stretch auto-sized items by default);stretchstretches items without an explicit size into the gap.All code is in the feature-gated
lanes.rs; the shared grid code is untouched. 14 new Chrome 151 fixtures (56 tests) intest_fixtures/grid_lanes/cover content distribution (center/end/safe/space-around), self-alignment (end/center/stretch/normal/align-self, with and without a stacking gutter), both directions, rtl and dense packing. All 204 lanes tests pass; the existing suites regenerate byte-identically.Context
alignment_space(LanePlacement) and, per track, the item placed last (last_in_track). Placing an item in a track closes the previous item's space in that track; after the container's stacking-axis size is known, the last items get the space up to the content box end. The item's stacking-axis area passed toalign_and_position_itemis its margin box plus that space, so the existing self-alignment code handles start/center/end/stretch.Openingnow carries the item placed before the skipped space (item_above), as Chromium'sTrackOpening::alignment_candidatedoes, so backfilling adjusts both items' spaces.stretch/normalis overridden tostarton the lanesGridItems:GridItem::known_dimensionswould otherwise return the stretched size as the item's contribution during placement (the container's stacking-axis size is the percentage basis). Positioning re-reads the styles, so stretch still applies there.Feedback wanted
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/93f06aa5dd4e4bc18d2482197dbb9191
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/93f06aa5dd4e4bc18d2482197dbb9191?variant=devin-insiders
Requested by: @nicoburns