Repository navigation
Conversation
…lerance to Taffy; pin Taffy lanes stack and Stylo grid-lanes branch
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
…tes; re-pin Taffy Per css-grid-3 §2.3, normal establishes rows when grid-template-columns is none and grid-template-rows is not, and columns otherwise. Re-pin Taffy to 72dedff2, which gives a grid axis with no explicit tracks one implicit track instead of panicking.
…43e63054 The CSSWG renamed the property (w3c/csswg-drafts#10884); Stylo keeps flow-tolerance as an alias.
staging-devin-ai-integration
Bot
changed the title
display: grid-lanes, grid-lanes-direction and flow-tolerance to Taffy (pins Taffy #1274, Stylo grid-lanes branch)display: grid-lanes, grid-lanes-direction and fit-tolerance to Taffy (pins Taffy #1274, Stylo grid-lanes branch)
staging-devin-ai-integration
Bot
changed the title
display: grid-lanes, grid-lanes-direction and fit-tolerance to Taffy (pins Taffy #1274, Stylo grid-lanes branch)display: grid-lanes, grid-lanes-direction and fit-tolerance to Taffy (pins Taffy #1275, Stylo grid-lanes branch)
… syntax removed, matching upstream main)
…under min-/max-content)
staging-devin-ai-integration
Bot
changed the title
display: grid-lanes, grid-lanes-direction and fit-tolerance to Taffy (pins Taffy #1275, Stylo grid-lanes branch)display: grid-lanes, grid-lanes-direction and fit-tolerance to Taffy (pins Taffy #1276, Stylo grid-lanes branch)
…ontainers in getComputedStyle
…asurement of auto-placed items)
…definite grid-axis size)
…-lanes # Conflicts: # Cargo.lock # Cargo.toml
…g+border floor, #1281 replaced-item alignment)
…-lanes # Conflicts: # Cargo.lock # Cargo.toml # packages/blitz-dom/src/resolved_style.rs
…-lanes # Conflicts: # Cargo.lock # Cargo.toml
…-lanes # Conflicts: # Cargo.lock # Cargo.toml
…-lanes # Conflicts: # Cargo.lock # Cargo.toml # packages/blitz-dom/src/resolved_style.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the new Grid Lanes layout mode (
display: grid-lanes, CSS Grid Level 3) from Stylo through to Taffy.243d109c, the head of the lanes stack (Grid Lanes:Display::GridLanes, style API, gentest support and waterfall layout driver taffy#1270 → #1272 → #1274 → #1275 → #1276), and Stylo to thedevin/1791478953-grid-lanes-props-0.22branch (ee927b58: Stylo v0.22.0 + upstreamdisplay: grid-lanes+ thegrid-lanes-directionandfit-tolerancelonghands, legacy masonry syntax removed as on upstream main). Thegrid-lanescargo feature ofstylo_taffyis enabled.stylo_taffy/convert.rs:display: grid-lanes→taffy::Display::GridLanes;grid_lanes_direction()mapsrow/columnand resolvesnormalthe way Chromium does (rows only whengrid-template-rowsis set andgrid-template-columnsis not);fit_tolerance()maps the length/percentage. The fourGenericGridTemplateComponent::Masonrymatch arms are gone with the Stylo bump.blitz-dom: lanes containers are treated like grid containers where Blitz special-cases grid: child collection inconstruct.rs(soorderapplies), the layout dispatch inlayout/mod.rs, andresolved_style.rs, which now substitutes used track sizes intogrid-template-rows/columnsfor grid-lanes containers as it does fordisplay: grid.WPT
css/css-grid/grid-lanesgoes from 36% to ~68% of subtests passing (see the WPT comment below); the remaining failures are mostly reverse directions (CSSWG 12803), subgrid, intrinsic auto-repeat, track-list interpolation and the Chromium-onlygrid-lanesshorthand /grid-lanes-pack.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/93f06aa5dd4e4bc18d2482197dbb9191
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/93f06aa5dd4e4bc18d2482197dbb9191?variant=devin-insiders
Requested by: @nicoburns
WPT results
Subtests: 1204 newly passing, 36 newly failing (net +1168).
Subtest changes by area (44 areas)
Full diff (442 changed tests)
Generated by the WPT workflow.