fix: apply theme values to new bookmarks#496
Open
nicode3141 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @zombieFox, could you please have a look at this? It's a bug fix to an annoying bug. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New bookmarks weren't inheriting theme properties like border size and opacity. Instead, they used default values (bookmarkDefault)
Demonstration
I've changed the opacity and border size in the theme and added new bookmarks. Those bookmarks don't have the same theme as the others do. Refreshing does not help here. Only when changing the theme's settings, the new bookmark is updated.
nighttab-bug-showcase.mp4
Changes
src/component/bookmark/index.jsAfter creating a bookmark, the theme gets applied to match the appearance of existing bookmarks.
Currently, this includes: