Repository navigation
refactor(structure): consolidate components into app/components - #732
Merged
Merged
Conversation
Move every component from the top-level components/ and src/components/ trees into app/components and update their imports. The virtualized src/components/TransactionsOfFury.tsx becomes VirtualizedTransactionsOfFury.tsx so it does not collide with the existing app/components/TransactionsOfFury.tsx, and the ErrorCard story now uses @storybook/nextjs like the other stories. Document the single component location in CONTRIBUTING.md and add an ESLint rule that fails on any file added to the retired trees.
|
@Vox-d-glitch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Vox-d-glitch is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved every component from the top-level
components/andsrc/components/trees intoapp/components/in one change, following the App Router convention of keeping app code underapp/, and updated the imports.src/components/TransactionsOfFury.tsx, the virtualized variant, would have collided with the existingapp/components/TransactionsOfFury.tsx, so it is nowVirtualizedTransactionsOfFury.tsx. The ErrorCard story now imports from@storybook/nextjslike the other stories, since it is now inside Storybook'sapp/**story glob.No
tsconfig.jsonalias pointed at the retired trees, so the@/*,@app/*and@src/*aliases stay as they are and the moved imports use the existing@/app/components/...and relative paths. CONTRIBUTING.md now explains where components live and why, and points the contact-list docs atapp/components/. A new ESLint rule fails on any file added undercomponents/orsrc/components/, so the fragmentation can't come back.Closes #588