Repository navigation
refactor(services): collapse indexer onto core and transport modules, delete dead paths - #727
Merged
Merged
Conversation
… delete dead paths
|
@No-bodyq is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@No-bodyq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I traced every indexer module to its consumers.
indexerCore.tsis the core: it fetches Horizon history and computes the result. The transport layer isindexerService.ts, the browser entry point with IndexedDB caching used by the loading page, andindexerServer.ts, the entry point the/api/wrappedroute uses.multiTimeframeIndexer.tsruns the browser transport across several periods and is reached throughmultiTimeframeStoreon the connect page.indexerRecoveryService.tswas only imported byuseIndexerRecovery, which nothing uses, so I deleted both. Undersrc/I deleted the placeholdersrc/services/indexerService.tsmock and thesrc/services/indexer/tree, whose index only re-exported an interface for an indexer that was never implemented. The Horizon record types that the achievement code still uses now live insrc/services/achievement/horizonTypes.ts. I also dropped therunIndexingCorere-export fromindexerService.tsso callers go through a transport.For tests, I removed
src/services/indexer/__tests__/indexer.service.test.ts, which tested that unimplemented interface, andapp/services/__tests__/indexerService.test.ts, a standalone script that exercised its own mock instead of any real module. The remaining indexer tests inapp/services/__tests__cover the surviving modules. The layering is described at the top ofindexerCore.tsand in the README's key components table.Closes #587