Repository navigation
ci: consolidate quality workflows and share setup via composite action - #726
Merged
Merged
Conversation
|
@No-bodyq is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@No-bodyq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
No-bodyq
force-pushed
the
fix/583-consolidate-ci-workflows
branch
from
October 1, 2026 22:48
59729d4 to
d57d9d5
Compare
Calebux
pushed a commit
that referenced
this pull request
Oct 6, 2026
…ign pnpm versions The workflow half is superseded: main no longer has the conflict markers and #726's setup action takes pnpm from packageManager. Keep the integrated workflows; the SocialIcons SVG cleanup merges as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, ESLint and Prettier ran in both
eslint.ymlandcode-quality.yml.code-quality.ymlalso ran typecheck and unit tests, andci.ymlran lint, typecheck, the unit suite repeatedly (test,test:componentsandtest:coveragein one job, plus a separate coverage job) and a Storybook build thatstorybook.ymlalso runs.I removed
eslint.ymland madecode-quality.ymlthe single authoritative ESLint, Prettier and TypeScript check.ci.ymlnow owns lock file validation, one unit test run with coverage, the production build and visual regression, and Storybook is built only instorybook.yml.The pnpm, Node.js, cache and install steps that every workflow repeated now live in one composite action,
.github/actions/setup. It takes the pnpm version frompackageManager, and each workflow keeps its existing Node version and lockfile mode. Pull requests that only touch Markdown ordocs/now skip the quality, test, build, Storybook, E2E, Lighthouse and bundle-size workflows. I documented which workflow owns which check in the CI section ofTESTING_STRATEGY.md.Closes #583