Repository navigation
fix(routing): lowercase vibe-check page file and guard route file casing in CI - #725
Merged
Merged
Conversation
|
@No-bodyq is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@No-bodyq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed
app/vibe-check/Page.tsxtopage.tsxwith a two-stepgit mvso the rename also registers on case-insensitive filesystems. With that change/vibe-checkbecame a real route on case-sensitive builds, which surfaced two problems that would still have broken it: the layout destructured a misspelledchildreenprop, so the page content never rendered, andScreen4VibeChecklazily imported anNftActivityCardcomponent that did not exist. I fixed the prop name and added a smallNftActivityCard, built the same way asBiggestDayCard, so the route builds and renders.I audited every route directory under
app/forpage,layout,loading,error,routeand the other App Router special files, andvibe-checkwas the only one with the wrong casing. To prevent this from happening again, I addedscripts/check-route-file-casing.mjs(also available aspnpm check:route-casing). It fails when any of those files underapp/is not lowercase, and it now runs as its own job inci.yml.Closes #582