Skip to content

fix(routing): lowercase vibe-check page file and guard route file casing in CI - #725

Merged
Calebux merged 1 commit into
zintarh:mainfrom
No-bodyq:fix/582-vibe-check-route-casing
Oct 1, 2026
Merged

Calebux merged 1 commit into
zintarh:mainfrom
No-bodyq:fix/582-vibe-check-route-casing

Conversation

@No-bodyq

Copy link
Copy Markdown
Contributor

I renamed app/vibe-check/Page.tsx to page.tsx with a two-step git mv so the rename also registers on case-insensitive filesystems. With that change /vibe-check became a real route on case-sensitive builds, which surfaced two problems that would still have broken it: the layout destructured a misspelled childreen prop, so the page content never rendered, and Screen4VibeCheck lazily imported an NftActivityCard component that did not exist. I fixed the prop name and added a small NftActivityCard, built the same way as BiggestDayCard, so the route builds and renders.

I audited every route directory under app/ for page, layout, loading, error, route and the other App Router special files, and vibe-check was the only one with the wrong casing. To prevent this from happening again, I added scripts/check-route-file-casing.mjs (also available as pnpm check:route-casing). It fails when any of those files under app/ is not lowercase, and it now runs as its own job in ci.yml.

Closes #582

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@No-bodyq is attempting to deploy a commit to the zintarh Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@No-bodyq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Calebux
Calebux merged commit 6c06c9d into zintarh:main Oct 1, 2026
4 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(routing): app/vibe-check/Page.tsx is capitalised, so the route 404s in production

2 participants