Repository navigation
Repo hygiene: remove scratch artifacts, consolidate docs, and dedupe useRecentLedgers - #724
Merged
Merged
Conversation
|
@charityagbenu12-cmd is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@charityagbenu12-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repo hygiene: remove scratch artifacts, consolidate docs, and dedupe useRecentLedgers
What was solved
#580 — chore(repo): delete the PR description files and merge script from the repository root
Remove committed scratch artifacts from the repository root (PR_DESCRIPTION_424.md, pr-description.md, pr_description_2.md, merge_loop.sh), untrack the committed Playwright test-results/ directory, and add generated output (test-results/, Playwright and Storybook build artifacts) to .gitignore, while confirming no CI workflow references the deleted files.
Addressed:
#581 — docs: eight overlapping markdown files at the root describe testing and transaction history
Consolidate the overlapping root-level markdown docs: merge the three transaction-history documents into one and the two testing documents into one, move retained docs under docs/, archive or delete per-delivery documents describing already-merged work, and add a docs index so contributors can find the right document.
Addressed:
#585 — refactor(structure):
useRecentLedgersexists twice, insrc/hooksandapp/hooksConsolidate the duplicated
useRecentLedgershook by diffingsrc/hooks/useRecentLedgers.tsagainstapp/hooks/useRecentLedgers.ts, keeping the current/intended implementation (perREACT_QUERY_RECENT_LEDGERS.md), deleting the stale copy, repointing all importers, deduplicating tests undersrc/hooks/__tests__andapp/hooks/__tests__, and adding a guard (lint rule or check) that fails when a hook filename exists in both trees.Addressed:
REACT_QUERY_RECENT_LEDGERS.mdat the root as the indicator of the intended one.useRecentLedgersimplementation and delete the other file.Changes
.gitignore(modify)docs/README.md(create)docs/TRANSACTION_HISTORY.md(create)src/hooks/useRecentLedgers.ts(modify)docs/TESTING.md(create)app/hooks/useRecentLedgers.ts(delete)Approach
useRecentLedgersexists twice, insrc/hooksandapp/hooks#585 — refactor(structure):useRecentLedgersexists twice, insrc/hooksandapp/hooks(Changed: src/hooks/useRecentLedgers.ts, app/hooks/useRecentLedgers.ts)Issues
Closes #580
Closes #581
Closes #585