Skip to content

Repo hygiene: remove scratch artifacts, consolidate docs, and dedupe useRecentLedgers - #724

Merged
Calebux merged 3 commits into
zintarh:mainfrom
charityagbenu12-cmd:drips/580-581-585
Oct 1, 2026
Merged

Calebux merged 3 commits into
zintarh:mainfrom
charityagbenu12-cmd:drips/580-581-585

Conversation

@charityagbenu12-cmd

Copy link
Copy Markdown
Contributor

Summary

Repo hygiene: remove scratch artifacts, consolidate docs, and dedupe useRecentLedgers

What was solved

#580 — chore(repo): delete the PR description files and merge script from the repository root

Remove committed scratch artifacts from the repository root (PR_DESCRIPTION_424.md, pr-description.md, pr_description_2.md, merge_loop.sh), untrack the committed Playwright test-results/ directory, and add generated output (test-results/, Playwright and Storybook build artifacts) to .gitignore, while confirming no CI workflow references the deleted files.

Addressed:

  • Changed: .gitignore
  • Delete PR_DESCRIPTION_424.md, pr-description.md, and pr_description_2.md from the repository root.
  • Delete merge_loop.sh from the repository root.
  • Remove test-results/ from version control and add it to .gitignore.

#581 — docs: eight overlapping markdown files at the root describe testing and transaction history

Consolidate the overlapping root-level markdown docs: merge the three transaction-history documents into one and the two testing documents into one, move retained docs under docs/, archive or delete per-delivery documents describing already-merged work, and add a docs index so contributors can find the right document.

Addressed:

  • Changed: docs/README.md, docs/TESTING.md, docs/TRANSACTION_HISTORY.md, docs/README.md
  • Merge TRANSACTION_HISTORY_DELIVERY.md, TRANSACTION_HISTORY_DOCUMENTATION.md, and TRANSACTION_HISTORY_IMPLEMENTATION.md into a single current transaction-history document.
  • Merge TESTING.md and TESTING_STRATEGY.md into a single current testing document.
  • Move the retained consolidated documents under docs/ (which currently holds a single file).

#585 — refactor(structure): useRecentLedgers exists twice, in src/hooks and app/hooks

Consolidate the duplicated useRecentLedgers hook by diffing src/hooks/useRecentLedgers.ts against app/hooks/useRecentLedgers.ts, keeping the current/intended implementation (per REACT_QUERY_RECENT_LEDGERS.md), deleting the stale copy, repointing all importers, deduplicating tests under src/hooks/__tests__ and app/hooks/__tests__, and adding a guard (lint rule or check) that fails when a hook filename exists in both trees.

Addressed:

  • Changed: src/hooks/useRecentLedgers.ts, app/hooks/useRecentLedgers.ts
  • Diff the two implementations and determine which is current, using REACT_QUERY_RECENT_LEDGERS.md at the root as the indicator of the intended one.
  • Keep exactly one useRecentLedgers implementation and delete the other file.
  • Repoint every importer of the removed hook to the surviving one so all resolve to a single module.

Changes

  • .gitignore (modify)
  • docs/README.md (create)
  • docs/TRANSACTION_HISTORY.md (create)
  • src/hooks/useRecentLedgers.ts (modify)
  • docs/TESTING.md (create)
  • app/hooks/useRecentLedgers.ts (delete)

Approach

  1. chore(repo): delete the PR description files and merge script from the repository root #580 — chore(repo): delete the PR description files and merge script from the repository root (Changed: .gitignore)
  2. docs: eight overlapping markdown files at the root describe testing and transaction history #581 — docs: eight overlapping markdown files at the root describe testing and transaction history (Changed: docs/README.md, docs/TESTING.md, docs/TRANSACTION_HISTORY.md, docs/README.md)
  3. refactor(structure): useRecentLedgers exists twice, in src/hooks and app/hooks #585 — refactor(structure): useRecentLedgers exists twice, in src/hooks and app/hooks (Changed: src/hooks/useRecentLedgers.ts, app/hooks/useRecentLedgers.ts)

Issues

Closes #580
Closes #581
Closes #585

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@charityagbenu12-cmd is attempting to deploy a commit to the zintarh Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@charityagbenu12-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Calebux
Calebux merged commit a37d683 into zintarh:main Oct 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants