Skip to content

Add comprehensive edge-case tests for Horizon error handler (Issue #463) - #722

Merged
Calebux merged 1 commit into
zintarh:mainfrom
coderolisa:feature/issue-463-rate-limit-tests
Oct 1, 2026
Merged

Calebux merged 1 commit into
zintarh:mainfrom
coderolisa:feature/issue-463-rate-limit-tests

Conversation

@coderolisa

Copy link
Copy Markdown
Contributor

closes #633

  • Add tests for 429 rate limiting with Retry-After header detection
  • Test distinction between 429 (retryable), 404 (terminal), and 5xx (retryable)
  • Cover all status classes: 4xx client errors, timeouts, and server errors
  • Add tests for rate limit header extraction and parsing
  • Test network connectivity errors (ECONNABORTED)
  • Cover edge cases: missing headers, malformed data, unknown errors
  • Add sustained rate limiting detection test for user feedback

This addresses 1% of issue #463 by ensuring proper error classification and retry behavior for different Horizon error scenarios.

…ntarh#463)

- Add tests for 429 rate limiting with Retry-After header detection
- Test distinction between 429 (retryable), 404 (terminal), and 5xx (retryable)
- Cover all status classes: 4xx client errors, timeouts, and server errors
- Add tests for rate limit header extraction and parsing
- Test network connectivity errors (ECONNABORTED)
- Cover edge cases: missing headers, malformed data, unknown errors
- Add sustained rate limiting detection test for user feedback

This addresses 1% of issue zintarh#463 by ensuring proper error classification
and retry behavior for different Horizon error scenarios.
@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@coderolisa is attempting to deploy a commit to the zintarh Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@coderolisa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Calebux
Calebux merged commit 116c772 into zintarh:main Oct 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(horizon): rate-limit responses are not handled distinctly from other failures

2 participants