Repository navigation
Conversation
- test(utils): add comprehensive edge-case tests for stellarAmount and stellarAmounts utilities covering null/undefined inputs, unexpected data types, boundary values, overflow/underflow, and round-trip invariants — closes zintarh#474 - feat(swap): implement TokenSwap component with full keyboard navigation (Tab order, Enter to submit, Escape to clear, Arrow keys on selects, focus management on success/error, aria-live announcements) — closes zintarh#476 - feat(swap): lazy-load TokenSwap via React.lazy + Suspense with a CLS-free skeleton placeholder to reduce initial bundle size — closes zintarh#475 - feat(withdraw): replace all inline styles with Tailwind utility classes; complete keyboard navigation (Enter submits, Escape clears, programmatic focus management on connect/error/success, aria-busy, aria-invalid, aria-live regions) — closes zintarh#477
|
@kelvin1john0901-blip is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@kelvin1john0901-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#474 — Stroops edge-case tests
empty strings, whitespace, negatives, scientific notation, overflow, boundary round-trips
#475 — Lazy-load Swap
#476 — Keyboard nav for Token Swap
Built directly into TokenSwap.tsx: Tab order, Enter submits, Escape clears amount, Arrow keys work on selects natively, aria-live announces direction/asset changes, focus moves to
error on failure and back to input on success, aria-busy/aria-invalid states.
#477 — Keyboard nav for Withdraw Flow
app/[locale]/withdraw/page.tsx rewritten: all inline style={{…}} props replaced with Tailwind classes, added Escape to clear amount, aria-busy on submit, better aria-label that
reads the current amount, aria-live="polite" on success banner, and isWithdrawing ordering fix.
closes #474
closes #475
closes #476
closes #477