Repository navigation
Fix/618 collapse kv layer - #703
Merged
Merged
Conversation
…pace, define failure modes Resolves the obscured storage boundary described in zintarh#618. - app/api/notifications/_lib/kv.ts: now imports storage helpers directly from ../../_lib/kv (no re-export chain). Adds full JSDoc for the notif:sub:, notif:period:, and notif:log: key families. Adds KV_FAILURE_LOUD / KV_FAILURE_DEGRADE constants and KvFailureMode type. - All six notification routes annotated with // KV_FAILURE: LOUD or DEGRADE at the import site. dispatch/subscribe/subscribe-email/confirm-email use ../_lib/kv; preferences/{wallet} and data/{wallet} use ../../_lib/kv (both resolve to the notifications _lib). - app/api/notifications/__tests__/kv.test.ts: 39 tests covering key builders, namespace isolation, failure-mode constants, storage helper re-exports, and LOUD vs DEGRADE caller behaviour (all green). Closes zintarh#618
|
@zintarh is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@AnnieIj Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the notification KV integration to establish a clear storage boundary, remove the redundant KV re-export, and make storage failure behaviour predictable across notification routes.
Changes Made
app/api/notifications/_lib/kv.ts.kvGet,kvSet,kvKeys, andkvSRem.SUB_KEY,PERIOD_KEY, andLOG_KEY.Expected Outcome
The application has one clearly defined KV storage module, one documented notification key namespace, and predictable failure handling for each notification operation.
Closes #618