Repository navigation
ci(bindings): build the iOS Binding Layer on every pull request - #2949
Merged
Merged
Conversation
The per-PR workflow built the Android Binding Layer on every pull request but called the iOS workflow only from the nightly, so a change that broke the Swift Binding Set surfaced a day late. This commit adds a binding-layer-ios job to ci-pr.yaml beside binding-layer-android. It calls binding-layer-ios.yaml on the same commit, which builds both XCFrameworks and the Swift sources on the WarpBuild macOS runner that workflow names. The nightly already runs its own iOS build and passes skip-binding-layer-build, so that flag now skips both per-PR Binding Layer builds and each tree builds iOS once. The comments that describe the flag and the nightly tier say so. ADR 0054 still describes the per-PR tier as the x86_64 AAR alone. The amendment belongs in the zingo-adrs repository. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
juanky201271
approved these changes
Oct 14, 2026
21 of 26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The per-PR workflow builds the Android Binding Layer on every pull request. It called the iOS workflow only from the nightly. This PR adds a
binding-layer-iosjob toci-pr.yamlbesidebinding-layer-android. The job callsbinding-layer-ios.yamlon the same commit. That workflow builds both XCFrameworks and the Swift sources on the WarpBuild macOS runnerwarp-macos-15-arm64-12x, or the runner that theCI_IOS_RUNNERvariable names.The nightly runs its own iOS build and passes
skip-binding-layer-build: true. That flag now skips both per-PR Binding Layer builds, so each tree builds iOS once. The comments on the flag and on the nightly tier say so.Why
A change that breaks the Swift Binding Set failed the nightly, one day after the pull request that made it. With this job it fails that pull request. The review of PR #2937 noted that no Mac had run its Swift wire-contract step. After #2937 merges
dev, its PR CI runs that step on the Mac.Follow-ups
ADR 0054 describes the per-PR tier as the x86_64 AAR alone. The amendment belongs in the zingo-adrs repository. Branch
devlists no required checks, so neither Binding Layer job gates a merge until one is added.🤖 Generated with Claude Code