Repository navigation
feat(address-book): Send picks the recipient from the address book - #1643
Merged
Merged
Conversation
The pill with the sliding thumb was drawn inline in Server. The address book picker needs the same control, so it moves to a widget both use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Avatar, name, short address and tag move out of ContactRow into AddressRowHead, which also draws the wallet avatar and the In use tag that the wallet's own addresses take in the picker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Send's book button opened a plain select sheet. It now opens the address book as a picker, as the prototype draws it: titled Choose a contact, with a Contacts / My wallet switch, no New contact and no row actions. Contacts lists only Zcash contacts; My wallet lists the addresses Receive offers, each with its tag, the newest unified one in use and transparent ones public. Tapping a row fills To. The button shows whenever the address is empty or saved, since the wallet tab always has entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Visual review — ✅ matches baselineHead vs |
The old picker offered the tagged own addresses only, and the book holds no others. My wallet now lists those, says how to tag one when there is none, and Send's book button shows again only when the picker has a Zcash contact or a tagged own address to offer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The card took its state from the error field alone, so a sync the system killed, one cancelled by the app in the foreground, one skipped offline and one that failed without error text all showed a green Finished OK. The outcome now comes from the file the native task writes: failed on an error or a KO message, interrupted without an end time, skipped on the offline message, ok otherwise. Reporting an error no longer clears it, so the user can report it again; the setter and the file writer that served that are gone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Added 908b1a2: the last-background-sync card on the sync report derives its outcome from background.json (ok / skipped / failed / did not finish) and no longer clears the error after reporting it. |
juanky201271
marked this pull request as ready for review
October 15, 2026 16:43
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send's address book button opens the address book as a picker, the prototype's last unported screen.
Shared pieces, no copies:
SegmentedSwitch, used by Server and the picker.AddressRowHead, used by contact rows and own-address rows.Not ported: the prototype's "My wallet · Unified. Only the network fee applies." line under To belongs to the Send screen, which the prototype does not get right yet.
🤖 Generated with Claude Code