Repository navigation
fix(uris): preserve explicit default ports before paths and queries - #1639
Open
skazistp-cpu wants to merge 1 commit into
Open
skazistp-cpu wants to merge 1 commit into
skazistp-cpu wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1639 +/- ##
==========================================
+ Coverage 53.60% 55.32% +1.71%
==========================================
Files 314 330 +16
Lines 11789 12225 +436
Branches 3153 3175 +22
==========================================
+ Hits 6320 6763 +443
- Misses 4532 4534 +2
+ Partials 937 928 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://example.com:443/pathbecomeshttps://example.com:9067. The URL parser omits an explicit default port, and the fallback searches the end of the full URI. Conversely, a path ending in:443selects port 443.Check the authority for an explicit default port. Add five regressions covering paths, queries, local HTTP and a port-like path suffix.
Validated against dev
7ce9ee5bon 15 October: all five new tests fail on the base and pass with the change. The focused parser tests pass 14/14, TypeScript passes, and the full suite passes 1000/1000 with 77 snapshots (--runInBand --forceExit, pinned submodules initialized). Base suite: 995/995. Device connection checks remain untested.Prepared with AI assistance by the Sebrona team, refreshed and tested with OpenAI Codex, and reviewed at the exact commit by a separate Codex AI agent. Miroslav / Sebrona is responsible for the submission.