Skip to content

fix(uris): preserve explicit default ports before paths and queries - #1639

Open
skazistp-cpu wants to merge 1 commit into
zingolabs:devfrom
skazistp-cpu:jarvis/server-uri-default-port-20261015
Open

skazistp-cpu wants to merge 1 commit into
zingolabs:devfrom
skazistp-cpu:jarvis/server-uri-default-port-20261015

Conversation

@skazistp-cpu

Copy link
Copy Markdown
Contributor

https://example.com:443/path becomes https://example.com:9067. The URL parser omits an explicit default port, and the fallback searches the end of the full URI. Conversely, a path ending in :443 selects port 443.

Check the authority for an explicit default port. Add five regressions covering paths, queries, local HTTP and a port-like path suffix.

Validated against dev 7ce9ee5b on 15 October: all five new tests fail on the base and pass with the change. The focused parser tests pass 14/14, TypeScript passes, and the full suite passes 1000/1000 with 77 snapshots (--runInBand --forceExit, pinned submodules initialized). Base suite: 995/995. Device connection checks remain untested.

Prepared with AI assistance by the Sebrona team, refreshed and tested with OpenAI Codex, and reviewed at the exact commit by a separate Codex AI agent. Miroslav / Sebrona is responsible for the submission.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.32%. Comparing base (737d156) to head (3eae550).
⚠️ Report is 98 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1639      +/-   ##
==========================================
+ Coverage   53.60%   55.32%   +1.71%     
==========================================
  Files         314      330      +16     
  Lines       11789    12225     +436     
  Branches     3153     3175      +22     
==========================================
+ Hits         6320     6763     +443     
- Misses       4532     4534       +2     
+ Partials      937      928       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant